Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When publishing an entity for test, at least 1 idp must be selected #1331

Open
teunfransen opened this issue Dec 13, 2024 · 1 comment · Fixed by #1334
Open

When publishing an entity for test, at least 1 idp must be selected #1331

teunfransen opened this issue Dec 13, 2024 · 1 comment · Fixed by #1334

Comments

@teunfransen
Copy link
Contributor

teunfransen commented Dec 13, 2024 •
edited by quartje
Loading

When publishing an entity to the TEST environment, the user is presented with an idp selection screen.
Currently we have no validation on that screen. This generates an error when a user selects no IdP's.

In the new IdP selection (/idps) menu, at least 1 idp must be selected. If no idp has been selected, the validation signals (like the validation messages in the entity creation screens) in red the following message:

No connection has been selected. Please provide at least one connection to continue
@teunfransen teunfransen converted this from a draft issue Dec 13, 2024
@teunfransen teunfransen moved this from Backlog to In Progress in sp-dashboard Dec 13, 2024
johanib added a commit that referenced this issue Dec 17, 2024
@johanib
Add validation: At least 1 idp must be selected
daea6e7 
Prior to this change, when no idp was selected in the Entity IDP
selection when publishing an Entity, the form validation would handle, and and error was thrown.

This change adds form validation that at least one IDP must be selected.

Resolves #1331
@johanib johanib mentioned this issue Dec 17, 2024
Merged
johanib added a commit that referenced this issue Dec 17, 2024
@johanib
Add validation: At least 1 idp must be selected
14a2665 
Prior to this change, when no idp was selected in the Entity IDP
selection when publishing an Entity, the form validation would handle, and and error was thrown.

This change adds form validation that at least one IDP must be selected.

Resolves #1331
johanib added a commit that referenced this issue Dec 17, 2024
@johanib
Add validation: At least 1 idp must be selected
1095c1b 
Prior to this change, when no idp was selected in the Entity IDP
selection when publishing an Entity, the form validation would handle, and and error was thrown.

This change adds form validation that at least one IDP must be selected.

Resolves #1331
@johanib johanib linked a pull request Dec 17, 2024 that will close this issue
Add validation: At least 1 idp must be selected #1334
Merged
johanib added a commit that referenced this issue Dec 17, 2024
@johanib
Add validation: At least 1 idp must be selected
676d082 
Prior to this change, when no idp was selected in the Entity IDP
selection when publishing an Entity, the form validation would handle, and and error was thrown.

This change adds form validation that at least one IDP must be selected.

Resolves #1331
@johanib johanib linked a pull request Dec 17, 2024 that will close this issue
Remove ACL idp selection screen #1335
Closed
@johanib
Copy link
Contributor

johanib commented Dec 17, 2024

Validation added in #1334

As discussed, the validation should also be implemented for the other screen.
But that screen is deprecated, and should be replaced:

#1335

@teunfransen teunfransen moved this from In Progress to External Testing in sp-dashboard Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
sp-dashboard
Status: External Testing
Milestone
No milestone
2 participants
@teunfransen @johanib