Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D8CORE-6952: changed to list style none #719

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Conversation

jenbreese
Copy link
Contributor

READY FOR REVIEW

Summary

  • added a list-style of none to remove the bullets

Review By (Date)

  • 10/11

Criticality

  • Normal

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Rebuild Cache and import config drush cr ; drush ci
  3. Navigate to the news, events, publications, people list page
  4. Verify there are no bullets in the list menu.

Site Configuration Sync

  • Is there a config:export in this PR that changes the config sync directory? NO

Front End Validation

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided? eg (unit, behat, or codeception)

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- D8CORE-6952

Resources

Copy link
Contributor

@jdwjdwjdw jdwjdwjdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@jdwjdwjdw jdwjdwjdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after you merged in the latest 11.x 👍

@jenbreese jenbreese merged commit c3cf258 into 11.x Oct 11, 2023
4 checks passed
@jenbreese jenbreese deleted the D8CORE-6952--filter-by branch October 11, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants