Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LL Function for checking UCPD RxErr Flag is missing #42

Open
ualbertagreen opened this issue Mar 1, 2023 · 2 comments
Open

LL Function for checking UCPD RxErr Flag is missing #42

ualbertagreen opened this issue Mar 1, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request hal HAL-LL driver-related issue or pull-request. internal bug tracker Issue confirmed and logged into the internal bug tracking system usb-pd USB Power-Delivery-related issue or pull-request

Comments

@ualbertagreen
Copy link

The function for checking is the RxErr flag is missing. Despite the fact the RxErr flag is defined in LL-UCPD, it is never used.

Additional context
If you have a first analysis or patch correction, thank you to share your proposal.

The function for checking RxErr flag should look like this:

/**
  * @brief  Check if Rx error interrupt
  * @rmtoll SR          RXERR         LL_UCPD_IsActiveFlag_RxErr
  * @param  UCPDx UCPD Instance
  * @retval None
  */
__STATIC_INLINE uint32_t LL_UCPD_IsActiveFlag_RxErr(UCPD_TypeDef const * const UCPDx)
{
  return ((READ_BIT(UCPDx->SR, UCPD_SR_RXERR) == UCPD_SR_RXERR) ? 1UL : 0UL);
}
@RJMSTM RJMSTM added hal HAL-LL driver-related issue or pull-request. usb Universal Serial Bus labels Mar 9, 2023
@RJMSTM RJMSTM added the enhancement New feature or request label Apr 27, 2023
@ALABSTM ALABSTM added the internal bug tracker Issue confirmed and logged into the internal bug tracking system label Feb 8, 2024
@ALABSTM
Copy link
Contributor

ALABSTM commented Feb 8, 2024

Hi @ualbertagreen,

Please excuse this delayed reply. Your request looks very legitimate. It has been forwarded to our development teams. I will keep you posted.

With regards,

@ALABSTM
Copy link
Contributor

ALABSTM commented Feb 8, 2024

ST Internal Reference: 173010

@ALABSTM ALABSTM added usb-pd USB Power-Delivery-related issue or pull-request and removed usb Universal Serial Bus labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hal HAL-LL driver-related issue or pull-request. internal bug tracker Issue confirmed and logged into the internal bug tracking system usb-pd USB Power-Delivery-related issue or pull-request
Projects
Status: In progress
Development

No branches or pull requests

3 participants