Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to cover minor BDD operations and operator overloads #611

Open
10 tasks
SSoelvsten opened this issue Feb 13, 2024 · 0 comments
Open
10 tasks

Add tests to cover minor BDD operations and operator overloads #611

SSoelvsten opened this issue Feb 13, 2024 · 0 comments
Labels
good first issue Good for newcomers 🎓 student programmer Work, work...

Comments

@SSoelvsten
Copy link
Owner

SSoelvsten commented Feb 13, 2024

Whlie looking through the diff for #610 , I found the following missing coverage. These should be tested to be working as expected, similar to the other functions.

Tasks

  • bdd_invimp
  • bdd_equiv
  • bdd_diff
  • bdd_less
  • bdd::bdd() (default construction to false)
  • bdd::operator |=
  • bdd::operator &=
  • bdd::operator ^=

Other

  • The definition of the binary bdd::operators should be moved from adiar/bdd/bdd.cpp into adiar/bdd/apply.cpp.
  • The definition of the binary bdd::operator== and its derivates should be moved to adiar/bdd/pred.cpp
@SSoelvsten SSoelvsten added good first issue Good for newcomers 🎓 student programmer Work, work... labels Feb 13, 2024
@SSoelvsten SSoelvsten added this to the v2.0 : API Revamp milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers 🎓 student programmer Work, work...
Projects
None yet
Development

No branches or pull requests

1 participant