Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consumer<int> overload for bdd_satmin and bdd_satmax #585

Open
3 tasks
SSoelvsten opened this issue Nov 28, 2023 · 0 comments
Open
3 tasks

Add consumer<int> overload for bdd_satmin and bdd_satmax #585

SSoelvsten opened this issue Nov 28, 2023 · 0 comments
Labels
📁 bdd Binary Decision Diagrams ✨ feature New operation or other feature good first issue Good for newcomers 🎓 student programmer Work, work...

Comments

@SSoelvsten
Copy link
Owner

SSoelvsten commented Nov 28, 2023

As a follow-up on #225 in conjunction with #556, the bdd_satmin and bdd_satmax should be overloaded with a consumer<int> where the signedness is used to reflect negation (potentially with an exception if zero is assigned anything?).

  • bdd_satmin(f, consumer<int>) and add unit tests
  • bdd_satmax(f, consumer<int>) and add unit tests
  • Add unit tests to check the iterator-based overloads work as expected with a std::vector<int> buffer.
@SSoelvsten SSoelvsten added ✨ feature New operation or other feature 📁 bdd Binary Decision Diagrams labels Nov 28, 2023
@SSoelvsten SSoelvsten added this to the v2.0 : API Revamp milestone Nov 28, 2023
@SSoelvsten SSoelvsten added good first issue Good for newcomers 🎓 student programmer Work, work... labels Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📁 bdd Binary Decision Diagrams ✨ feature New operation or other feature good first issue Good for newcomers 🎓 student programmer Work, work...
Projects
None yet
Development

No branches or pull requests

1 participant