Deprecate and make support of 'ad_allow_remote_domain_local_groups' #7741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumit-bose
reviewed
Dec 5, 2024
| [ AC_ARG_WITH([allow-remote-domain-local-groups], | ||
| [AC_HELP_STRING([--with-allow-remote-domain-local-groups], | ||
| [Whether to build support of ad_allow_remote_domain_local_groups | ||
| sssd.conf option [no].] |
There was a problem hiding this comment.
Hi,
I would like to suggest to mention here as well that the option is deprecated.
bye,
Sumit
There was a problem hiding this comment.
Fixed (and rebased).
sssd.conf option conditional :config: 'ad_allow_remote_domain_local_groups' option is deprecated and will be removed in future releases. :packaging: Support of deprecated 'ad_allow_remote_domain_local_groups' sssd.conf option isn't built by default. It can be enabled using '--with-allow-remote-domain-local-groups' ./configure option.
alexey-tikhonov
force-pushed
the
remote-domain-local
branch
from
b1ec38c to
9480d55
Compare
sumit-bose
approved these changes
Dec 5, 2024
alexey-tikhonov
added
Accepted
Ready to push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sssd.conf option conditional
:config: 'ad_allow_remote_domain_local_groups' option is deprecated and will be removed in future releases.
:packaging: Support of deprecated 'ad_allow_remote_domain_local_groups' sssd.conf option isn't built by default. It can be enabled using '--with-allow-remote-domain-local-groups' ./configure option.