-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add feature presence automation #7740
base: master
Are you sure you want to change the base?
Conversation
Hi, this looks pretty good but there are some failures in the tests so we need to double check if the features should (not) be present. |
5d34095
to
3a05680
Compare
I checked it with Alexey and the spec file to make sure everything is right. This is ready for review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ikerexxe I wonder if we want more parts something for 2.9.5-4.el9_5.2 etc. as some feature like exop_force might land in different versions across different rhel versions. |
That's what RHEL major and minor versions are for. Or do you mean some other thing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good for a quick assertion to ensure the feature is present or not. I did like @jakub-vavra-cz idea to associate the condition in the test, so it will skip or run, not just feature checking. Maybe we can return to that topic next year.
So just the minor nitpick comments, thank you Iker.
3a05680
to
e2f0728
Compare
The test case can be further extended to cover other features by using the parametrization that is already in place. Signed-off-by: Iker Pedrosa <[email protected]>
e2f0728
to
769f619
Compare
@danlavu @jakub-vavra-cz I would like to have this merged before the vacation period, so please do a final review. We can always expand the test case in the future to include additional information as needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG2M
The test case can be further extended to cover other features by using the parametrization that is already in place.