build with OpenSSL 1.1 is broken #7735
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumit-bose
reviewed
Dec 3, 2024
src/util/cert/libcrypto/cert.c
Outdated
| @@ -406,16 +416,16 @@ static int sss_rsa_get_key(const EVP_PKEY *cert_pub_key, | |||
|
|
|||
| RSA_get0_key(rsa_pub_key, tmp_n, tmp_e, NULL); | |||
There was a problem hiding this comment.
Hi,
I'm sorry for all the typos, I was under the assumption the one of the CI systems is still using OpenSSL-1.1 so I assumed that everything was fine if all CI builds succeeded.
In the patch for sssd-2-9 you have + RSA_get0_key(rsa_pub_key, &tmp_n, &tmp_e, NULL); and it looks like I need this for master too, to not get incompatible-pointer-types warnings.
bye,
Sumit
There was a problem hiding this comment.
Sorry, it looks like my merge mistake. I fixed it and pushed with force.
alexey-tikhonov
added
Waiting for review
Ready to push
alexey-tikhonov
approved these changes
Dec 6, 2024
|
Thank you, ACK. |
sumit-bose
reviewed
Dec 10, 2024
Don't include <openssl/core_names.h> header if OpenSSL older 3.0 is used. Fix compile typos for build with OpenSSL 1.1.
sumit-bose
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cert util: add support build with OpenSSL older than 3.0: