Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch sssd-2-9 build with OpenSSL 1.1 is broken #7733

Closed
wants to merge 1 commit into from

Conversation

mastersin
Copy link
Contributor

cert util: add support build with OpenSSL older than 3.0:

  • Don't include <openssl/core_names.h> header if OpenSSL older 3.0 is used.
  • Fix compile typos for build with OpenSSL 1.1.

Don't include <openssl/core_names.h> header if OpenSSL older 3.0 is
used. Fix compile typos for build with OpenSSL 1.1.
@alexey-tikhonov
Copy link
Member

@mastersin,

From sssd-2.9.5 build with OpenSSL 1.1 is broken

Do you mean since dfcfa51 ?
But that's not part of sssd-2.9.5...

Anyway, could you please fix 'master' (and thus sssd-2-10) branch as well?

@mastersin mastersin changed the title From sssd-2.9.5 build with OpenSSL 1.1 is broken branch sssd-2-9 build with OpenSSL 1.1 is broken Dec 2, 2024
@mastersin
Copy link
Contributor Author

mastersin commented Dec 2, 2024

src/util/cert/libcrypto/cert.c

Do you mean since dfcfa51 ? But that's not part of sssd-2.9.5...

Yes, of course. I renamed title of this PR.

Anyway, could you please fix 'master' (and thus sssd-2-10) branch as well?

It looks some different. Ok, I will try to fix it too.

@alexey-tikhonov alexey-tikhonov added the no-backport This should go to target branch only. label Dec 2, 2024
@mastersin
Copy link
Contributor Author

Another PR #7734 prepared for sssd-2-10 branch.

Copy link
Contributor

@sumit-bose sumit-bose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thank you for the fixes they work in my tests with OpenSSL-1.1.1k. Again, I'm sorry for not making sure my changes were tested properly with older OpenSSL versions. ACK.

bye,
Sumit

@pbrezina
Copy link
Member

pbrezina commented Dec 4, 2024

Pushed PR: #7733

  • sssd-2-9
    • 710a993 - cert util: add support build with OpenSSL older than 3.0

@pbrezina pbrezina added Pushed and removed Accepted Ready to push Ready to push labels Dec 4, 2024
@pbrezina pbrezina closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport This should go to target branch only. Pushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants