Tests: SSSD fails to store users if any of the requested attribute is… #7714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborah-sudo
force-pushed
the
test_ldap__empty_attribute
branch
2 times, most recently
from
0aee34f to
49a6ad4
Compare
src/tests/system/tests/test_ldap.py
Outdated
|
|
||
| assert client.tools.id("emp_user") is not None | ||
| assert client.tools.getent.group("Group_1") is not None | ||
| assert client.tools.getent.group("Group_2") is not None |
There was a problem hiding this comment.
I do not see a point in having/checking two groups there. Maybe the user should try to log in instead and the default/fallback home should be used as a check.
ikerexxe
reviewed
Nov 22, 2024
src/tests/system/tests/test_ldap.py
Outdated
| 2. Add a User | ||
| 3. Create an Organizational Unit | ||
| 4. Add Groups | ||
| 5. Configure SSSD |
There was a problem hiding this comment.
I guess you mean Start SSSD
aborah-sudo
force-pushed
the
test_ldap__empty_attribute
branch
2 times, most recently
from
6280e6e to
969e1ad
Compare
ikerexxe
reviewed
Nov 25, 2024
src/tests/system/tests/test_ldap.py
Outdated
| 1. Disable Syntax Checking | ||
| 2. Add a User | ||
| 3. Make home attribute of user empty | ||
| 4. Create an Organizational Unit |
There was a problem hiding this comment.
Where are you creating the organizational unit?
src/tests/system/tests/test_ldap.py
Outdated
| 5. Add Groups | ||
| 6. Start SSSD | ||
| :steps: | ||
| 1. The user can be queried (id command) |
There was a problem hiding this comment.
s/The user can be queried (id command)/User exists
src/tests/system/tests/test_ldap.py
Outdated
| 6. Start SSSD | ||
| :steps: | ||
| 1. The user can be queried (id command) | ||
| 2. Groups are resolved properly using the getent group command |
There was a problem hiding this comment.
s/Groups are resolved properly using the getent group command/Groups are resolved
No need to explain how in the steps, just the what.
… empty SSSD fails to store users if any of the requested attribute is empty
aborah-sudo
force-pushed
the
test_ldap__empty_attribute
branch
from
969e1ad to
0b88463
Compare
jakub-vavra-cz
approved these changes
Nov 29, 2024
jakub-vavra-cz
added
Accepted
Ready to push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… empty
SSSD fails to store users if any of the requested attribute is empty