CLIENT:PAM: replace deprecated _pam_overwrite
#7615
Conversation
src/sss_client/pam_sss.c
Outdated
| @@ -50,6 +50,8 @@ | |||
| #include "util/authtok-utils.h" | |||
| #include "util/dlinklist.h" | |||
|
|
|||
| void sss_erase_mem_securely(void *p, size_t size); /* from memory_erase.c */ | |||
There was a problem hiding this comment.
This function is declared in the util.h header file. Redeclaring it here is not a good idea.
There was a problem hiding this comment.
sss_client code doesn't include 'util.h' (for a reason - to not pull any dependencies like 'talloc' etc)
There was a problem hiding this comment.
I do not have strong opinion on this, but what about moving the declaration to memory_erase.h?
There was a problem hiding this comment.
I can add it if you'd like but I personally don't like adding headers for the sake of one function declaration.
There was a problem hiding this comment.
I like Tomas' idea. This new header file can be included from util.h so that no other change is required, and included directly from the C files that use only this function. But do it as you feel it.
There was a problem hiding this comment.
Ok, added a new header.
alexey-tikhonov
force-pushed
the
pam-handle-deprecation
branch
from
c91508b to
f115bde
Compare
|
distcheck fails: |
alexey-tikhonov
force-pushed
the
pam-handle-deprecation
branch
from
f115bde to
40c74d8
Compare
|
Fixed. |
|
@aplopez, do you want a second look? |
LGTM. |
with
sss_erase_mem_securely()And revert ef014b8.