tests: removing intg/ts_cache.py

[danlavu]

the following test cases are now covered in system/test_cache.py and this can be removed.

• fixed assertion writes_to_both_databases tests
• added test detecting modification and deletion for groups
  • test is a common user story and functional, changed priority to critical
• added "integration" test invalidating user, group, netgroup objects

[shridhargadekar]

The following test cases are covered in system/test_cache.py

Could you share where exactly these tests getting covered in system/test_cache.py?
Some of old test cases have set up related to rfc2307bis, where these scenarios are being covered

[shridhargadekar]

Could you share where exactly these rfc2307bis related tests getting covered in system/test_cache.py?

[alexey-tikhonov]

CI is red

[danlavu]

@shridhargadekar It's not. We're not porting tests, the coverage is related to cache timestamp in ldb which is covered.

I asked the team how to determine what LDAP tests we should test against rfc2307 and rfc2307bis, but we can easily take any test and parameterize the test to re-run it against 2307bis, so this can easily be done later.

[shridhargadekar]

@danlavu not all tests have the coverage, specifically L655 L628
These scenarios do not have coverage.
The way these tests running is bit different from what tests/test_cache.py

[shridhargadekar]

If missing coverage is done later then consider approval from me.

[danlavu]

@shridhargadekar
I admit, I didn't take a super close look at the test cases. I'm going to go through them today and will probably end up writing tests for them.

[danlavu]

I added two tests that cover the missing scenarios you mentioned.

Test that ensures the group changes are reflected after a clear
Another test, that ensures the cache records the change when that object type is cleared.

Updated the assertion for one of the tests that was confusing, mentioned in slack.

[danlavu]

Tests are not green, looking into it.

[danlavu]

The test was not working correctly, it was passing when there were no results, fixed now.

[danlavu]

@alexey-tikhonov, I converted all the tests to use the LDAP provider, as we discussed, and I corrected the logic; it's working now and not being skipped. I did notice that netgroups in the timestamp cache is empty. There is nothing in the results. Do you know if netgroups is supposed to write to the timestamp cache?

[alexey-tikhonov]

@shridhargadekar, please review the latest version.

[danlavu]

The failure is not related to the patch.

[alexey-tikhonov]

@danlavu, there is a conflict in sssd-2-9, please open explicit backport PR if needed.

[alexey-tikhonov]

Pushed PR: #7580

• master
  • d5b6484 - tests: converting all the ldb cache tests to use one provider
  • be0c232 - tests: removing intg/ts_cache.py
• sssd-2-10
  • 0ceefae - tests: converting all the ldb cache tests to use one provider
  • c6b9e26 - tests: removing intg/ts_cache.py