Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: multihost/basic/test_kcm converted #6990

Closed
wants to merge 1 commit into from
Closed

tests: multihost/basic/test_kcm converted #6990

wants to merge 1 commit into from

Conversation

patriki01
Copy link
Contributor

No description provided.

@patriki01 patriki01 force-pushed the kcm_tests branch 2 times, most recently from 6e420aa to 6eaf487 Compare December 15, 2023 10:20
@patriki01 patriki01 force-pushed the kcm_tests branch 2 times, most recently from 2def719 to b7a9955 Compare February 8, 2024 07:02
@patriki01 patriki01 marked this pull request as ready for review February 8, 2024 07:03
danlavu
danlavu requested changes Feb 8, 2024
View reviewed changes
src/tests/system/tests/test_kcm.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_kcm.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_kcm.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_kcm.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_kcm.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_kcm.py Show resolved Hide resolved
src/tests/system/tests/test_kcm.py Outdated Show resolved Hide resolved
src/tests/system/tests/test_kcm.py Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 13, 2024
View reviewed changes
src/tests/system/tests/test_kcm.py Fixed Show resolved Hide resolved
thalman
thalman requested changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test looks good. Thanks for good job. Just remove the "import re" and I will ACK it

src/tests/system/tests/test_kcm.py Fixed Show resolved Hide resolved
danlavu
danlavu approved these changes Feb 15, 2024
View reviewed changes
Copy link

@danlavu danlavu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better thank you Patrik

@patriki01
Copy link
Contributor Author

Thanks for feedback, test failures are unrelated

thalman
thalman approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Patrik, ACK

@pbrezina pbrezina added the Ready to push Ready to push label Feb 16, 2024
@jakub-vavra-cz
Copy link
Contributor

Pushed PR: #6990

  • master
    • e235afe - tests: multihost/basic/test_kcm converted
  • sssd-2-9
    • 566ebfb - tests: multihost/basic/test_kcm converted

@jakub-vavra-cz jakub-vavra-cz removed the Ready to push Ready to push label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlavu danlavu danlavu approved these changes

@thalman thalman thalman approved these changes

Assignees

@thalman thalman

@danlavu danlavu

Labels
Pushed Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@patriki01 @jakub-vavra-cz @thalman @danlavu @pbrezina @alexey-tikhonov