NSS: Replace notification message by a less scary one #6967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikerexxe
approved these changes
Oct 4, 2023
sumit-bose
requested changes
Oct 4, 2023
aplopez
force-pushed
the
message
branch
2 times, most recently
from
ee3fa93 to
288c1bd
Compare
sumit-bose
approved these changes
Oct 5, 2023
Replace the message "Unable to find primary gid" by another one that sounds less scary and is a little bit clearer for users.
alexey-tikhonov
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is no override, replace the message "Unable to find primary gid" by "There is no override for this group" which sound less scary and is a little bit clearer for users.
Why two different message depending on the returned error code?
Because
ENOENT, although an error from the LDAP/LDB point of view (the requested entry does not exist) is not an error for SSSD. It is legal that the entry doesn't exist. This just means that there is no override, but it is not an error.Any other error code (except
EOK, of course) represents a real error and we log a more meaningful message including the error code.Why doing this?
@alexey-tikhonov had already changed the debug level from
SSSDBG_MINOR_FAILUREtoSSSDBG_FUNC_DATAfor the message whenENOENTwas returned, because users where scared by this message. It seems that wasn't enough and users are still getting scared by this message.Resolves: https://issues.redhat.com/browse/SSSD-6770