Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

‘CURLOPT_PROTOCOLS’ is deprecated #6922

Closed
alexey-tikhonov opened this issue Sep 11, 2023 · 1 comment
Closed

‘CURLOPT_PROTOCOLS’ is deprecated #6922

alexey-tikhonov opened this issue Sep 11, 2023 · 1 comment
Assignees
@sumit-bose
Labels
Closed: Fixed Issue was closed as fixed. Future work

Comments

@alexey-tikhonov
Copy link
Member

../src/oidc_child/oidc_child_curl.c: In function ‘set_http_opts’:
../src/oidc_child/oidc_child_curl.c:125:5: warning: ‘CURLOPT_PROTOCOLS’ is deprecated: since 7.85.0. Use CURLOPT_PROTOCOLS_STR [-Wdeprecated-declarations]
125 | res = curl_easy_setopt(curl_ctx, CURLOPT_PROTOCOLS, CURLPROTO_HTTPS);
| ^~~
In file included from ../src/oidc_child/oidc_child_curl.c:26:
/usr/include/curl/curl.h:1753:3: note: declared here
1753 | CURLOPTDEPRECATED(CURLOPT_PROTOCOLS, CURLOPTTYPE_LONG, 181,
| ^~~~~~~~~~~~~~~~~
sumit-bose added a commit to sumit-bose/sssd that referenced this issue Sep 6, 2024
@sumit-bose
oidc_child: use CURLOPT_PROTOCOLS_STR if available
e12a1e4 
Since curl version 7.85.0 CURLOPT_PROTOCOLS is deprecated and should be
replaced by CURLOPT_PROTOCOLS_STR.

Resolves: SSSD#6922
@sumit-bose sumit-bose mentioned this issue Sep 6, 2024
Closed
alexey-tikhonov pushed a commit that referenced this issue Sep 13, 2024
@sumit-bose @alexey-tikhonov
oidc_child: use CURLOPT_PROTOCOLS_STR if available
cdb9d69 
Since curl version 7.85.0 CURLOPT_PROTOCOLS is deprecated and should be
replaced by CURLOPT_PROTOCOLS_STR.

Resolves: #6922

Reviewed-by: Alexey Tikhonov <[email protected]>
Reviewed-by: Pavel Březina <[email protected]>
(cherry picked from commit a331140)
@alexey-tikhonov
Copy link
Member Author

Pushed PR: #7575

  • master
    • a331140 - oidc_child: use CURLOPT_PROTOCOLS_STR if available
  • sssd-2-9
    • cdb9d69 - oidc_child: use CURLOPT_PROTOCOLS_STR if available

@alexey-tikhonov alexey-tikhonov added the Closed: Fixed Issue was closed as fixed. label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sumit-bose sumit-bose

Labels
Closed: Fixed Issue was closed as fixed. Future work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

oidc_child: use CURLOPT_PROTOCOLS_STR if available sumit-bose/sssd
3 participants
@andreboscatto @sumit-bose @alexey-tikhonov