Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio track and subtitle analytics #508

Closed
5 tasks done
defagos opened this issue Aug 4, 2023 · 3 comments · Fixed by #552
Closed
5 tasks done

Audio track and subtitle analytics #508

defagos opened this issue Aug 4, 2023 · 3 comments · Fixed by #552
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@defagos
Copy link
Member

defagos commented Aug 4, 2023

As an ADI analyst I want to be able to know whether audio tracks or subtitles have been enabled or not, and which ones.

Acceptance criteria

  • Track-related fields are properly sent in Commanders Act streaming analytics.

Tasks

  • Discuss forced subtitles. Should we send the subtitle language? (likely not since there is no involved user selection)
  • Discuss automatic selection. Should we send the subtitle language? (likely yes since there is a selection involved) If yes then add a method to get the low-level selection, e.g. activeMediaOption(for:).
  • Send media_audio_track in Commanders Act analytics (UND if none).
  • Send media_subtitle_selection and media_subtitles_on in Commander Act analytics (UND if none).
  • Ensure forced subtitles are not sent.
@defagos defagos added this to Pillarbox Aug 4, 2023
@defagos defagos converted this from a draft issue Aug 4, 2023
@defagos defagos moved this from ✏️ Draft to 📋 Backlog in Pillarbox Aug 4, 2023
@defagos defagos added the enhancement New feature or request label Aug 4, 2023
@defagos defagos changed the title Subtitle analytics Subtitle and audio track analytics Aug 4, 2023
@defagos defagos changed the title Subtitle and audio track analytics Audio track and subtitle analytics Aug 4, 2023
@defagos defagos added this to the Tracks milestone Aug 4, 2023
@defagos
Copy link
Member Author

defagos commented Aug 29, 2023

We asked ADI for information, most notably regarding forced subtitles.

@defagos
Copy link
Member Author

defagos commented Sep 1, 2023

I updated our common documentation issue with answers from ADI regarding subtitles. Also check this comment for optionality.

@defagos defagos moved this from 📋 Backlog to 🚧 In Progress in Pillarbox Sep 1, 2023
@waliid waliid linked a pull request Sep 4, 2023 that will close this issue
5 tasks
@defagos
Copy link
Member Author

defagos commented Sep 4, 2023

The specifications we have implemented are a best effort, as they were during the Letterbox area. We namely never notify audio or subtitle selection changes, each event merely reflects the current value when it is sent.

With Pillarbox asynchronously responding to changes the play event is recorded before selections are applied, thus subtitles will not be seen as enabled in initial play events, most notably. This status is updated in subsequent events like pos, though, thus this should be acceptable.

If this proves to be an issue in the future:

  • Maybe the specifications should be improved (e.g. a dedicated event should be sent).
  • Or our tracker implementation should combine playback state, seeking state as well as media selection availability somehow.

@github-project-automation github-project-automation bot moved this from 🚧 In Progress to ✅ Done in Pillarbox Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants