Never return chapters for audio content (#842)

SRGSSR · Apr 23, 2024 · ce46a19 · ce46a19
1 parent 80f5526
commit ce46a19
Show file tree

Hide file tree

Showing 5 changed files with 772 additions and 1 deletion.
diff --git a/Sources/CoreBusiness/Model/MediaComposition.swift b/Sources/CoreBusiness/Model/MediaComposition.swift
@@ -20,7 +20,8 @@ public struct MediaComposition: Decodable {
 
     /// The available chapters.
     public var chapters: [Chapter] {
-        _chapters.filter { $0.fullLengthUrn == chapterUrn && $0.mediaType == mainChapter.mediaType }
+        guard mainChapter.mediaType == .video else { return [] }
+        return _chapters.filter { $0.fullLengthUrn == chapterUrn && $0.mediaType == mainChapter.mediaType }
     }
 
     /// The related show.

diff --git a/Tests/CoreBusinessTests/MediaCompositionTests.swift b/Tests/CoreBusinessTests/MediaCompositionTests.swift
@@ -19,4 +19,9 @@ final class MediaCompositionTests: XCTestCase {
         let mediaComposition = Mock.mediaComposition(.mixed)
         expect(mediaComposition.chapters.count).to(equal(10))
     }
+
+    func testAudioChapterRemoval() {
+        let mediaComposition = Mock.mediaComposition(.audioChapters)
+        expect(mediaComposition.chapters).to(beEmpty())
+    }
 }
diff --git a/Tests/CoreBusinessTests/Mock.swift b/Tests/CoreBusinessTests/Mock.swift
@@ -17,6 +17,7 @@ enum Mock {
         case onDemand
         case redundant
         case mixed
+        case audioChapters
     }
 
     static func mediaComposition(_ kind: MediaCompositionKind = .onDemand) -> MediaComposition {

diff --git a/...CoreBusinessTests/Resources.xcassets/MediaComposition_audioChapters.dataset/Contents.json b/...CoreBusinessTests/Resources.xcassets/MediaComposition_audioChapters.dataset/Contents.json
@@ -0,0 +1,12 @@
+{
+  "data" : [
+    {
+      "filename" : "urn_rts_audio_13598743.json",
+      "idiom" : "universal"
+    }
+  ],
+  "info" : {
+    "author" : "xcode",
+    "version" : 1
+  }
+}