Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SBEReader #59

Open
2 tasks
Klankers opened this issue Jun 14, 2024 · 2 comments
Open
2 tasks

Replace SBEReader #59

Klankers opened this issue Jun 14, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Klankers
Copy link
Contributor

Klankers commented Jun 14, 2024

The SBEReader is old, takes ages, and isn't implemented as well as it could be.

  • Implement new reader for comparison to the old one during ARC01
  • Add R2R style checks to assess SBE raw files for various bad things, like non-real lat/lon or line errors

It should act as a springboard to overhauling CTDCAL to use Numpy and Xarray throughout for additional speed

Some desired changes and features identified from TODOs in ctdcal are listed below, so that the TODOs can be pruned.

  • Eliminate the Seabird sensor lookup table, or if not possible, consider whether it should be relocated in another module.
  • Add/improve error handling.
  • Add ability to substitute secondary channel for processing and derived variables.
@Klankers Klankers added the enhancement New feature or request label Jun 14, 2024
@Klankers Klankers added this to the Final beta v0.1.5 milestone Jun 14, 2024
@Klankers
Copy link
Contributor Author

Klankers commented Sep 3, 2024

Child or related strongly to #111 , #112 , #117, #118

@DocOtak
Copy link
Contributor

DocOtak commented Sep 5, 2024

Do you want to merge in or rely on this (might be a private repo)? https://github.com/cchdo/sbe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants