Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST add unit test to check test_calculate_anat_metrics #20

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Conversation

htwangtw
Copy link
Collaborator

Try to probe on #19

@clarkenj you can modify the code of this test to directly check if the bids layout was correctly generated, or any input from the preprocessing really!

Thanks to this issue I realised I don't have a unit test for this function!

Copy link
Collaborator

@clarkenj clarkenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@htwangtw
Copy link
Collaborator Author

htwangtw commented Aug 29, 2023

I will not mark #19 as fixed yet as we are still not sure what's the issue of running this on your dataset. Thanks for the review!

@htwangtw htwangtw merged commit 2db8eeb into main Aug 29, 2023
10 checks passed
@htwangtw htwangtw deleted the anat-ref branch August 29, 2023 18:19
htwangtw added a commit that referenced this pull request Aug 29, 2023
htwangtw added a commit that referenced this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants