Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I would like to ask about the paper on code correspondence #1

Closed
chenzhaoxingxin opened this issue May 1, 2023 · 11 comments
Closed

Comments

@chenzhaoxingxin
Copy link

Dear author:
Hello, thank you very much for publishing the code to help us learn. The example in your code is very effective. I would like to learn about discontinuous finite element knowledge based on the code. So, I would like to ask you, what equation does your code solve for? Is there any relevant article that can help us understand?
Thank you for taking the time to check my information. I wish you good health and smooth work. Looking forward to your reply!

@SIKtt
Copy link
Owner

SIKtt commented May 6, 2023

It based on Fast sweeping Method for Eikonal equation(Zhao, 2005) and a simplifed DG Method refer to (Li & Shu, 2007).

@chenzhaoxingxin
Copy link
Author

Thank you for your reply!
I have read the article (Li & Shu, 2007), which uses the Fast sweeping Method to obtain the initial solution, and then uses the DG method to further solve it. But his grid is a rectangular grid, and your grid uses a triangular grid, right? On the basis of the triangular mesh, first use the Fast sweeping Method to obtain the initial solution, and then use the DG method to further obtain the travel time solution, right?

@SIKtt
Copy link
Owner

SIKtt commented May 6, 2023

The method you mentioned above might be a good way to get the solution. If you are interested in getting Traveltime in Tri-mesh Luo, 2007 with DG realization, I recommend with related work of Shu(Semi-Discretization).

@chenzhaoxingxin
Copy link
Author

Sorry, I didn't quite understand what you meant. You mentioned the a simplifed DG Method in your previous email. That's why I want to confirm if you used the DG method when solving eikonal?

@SIKtt
Copy link
Owner

SIKtt commented May 6, 2023

Both scripts in this repo used FD solver.

@chenzhaoxingxin
Copy link
Author

Thank you for your reply. I encountered this issue while running the code. I'm not sure if you have encountered it before, and how can I solve it?
image

@SIKtt
Copy link
Owner

SIKtt commented May 6, 2023

Using its data and type property instead of casting CellBlock object to List.

@SIKtt
Copy link
Owner

SIKtt commented May 6, 2023

cannot unpack non-iterable CellBlock object

cellList = np.array(mesh.cells[1].data)

SIKtt added a commit that referenced this issue May 6, 2023
fix duplicate usage #1
@SIKtt SIKtt mentioned this issue May 6, 2023
@chenzhaoxingxin
Copy link
Author

Thanks! I would also like to ask that for rectangular grids, the fast scanning method is relatively easy to achieve by scanning in different directions. It is quite difficult to scan unstructured meshes such as triangular meshes. How do you sort triangular meshes and then scan them? Is there any relevant paper that can help understand?

@SIKtt
Copy link
Owner

SIKtt commented May 6, 2023

According to Luo(2007), cells can be sorted by its distance from reference points. This script just calc its distance in time. And you can storage distance in Heap to get a better performance.

@chenzhaoxingxin
Copy link
Author

Thank you very much. I will go and read the relevant papers.

@SIKtt SIKtt closed this as completed May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants