Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing proper exception mapdesign without player #32

Open
sven4all opened this issue Jun 19, 2014 · 2 comments
Open

Missing proper exception mapdesign without player #32

sven4all opened this issue Jun 19, 2014 · 2 comments

Comments

@sven4all
Copy link

If a user tries to parse a map without putting a player on that map, an IndexOutOfBoundsException will be thrown. This exception doesn't tell the user anything about his possible error. It would be better to throw a PacManConfigurationException, because this will tell the user what is going wrong, and gives an indication as to how this problem can be fixed.
@avandeursen
Copy link
Member

Linking to the fix in #33.

@TimvdLippe
Copy link
Contributor

An invariant exists here. Can we close this issue or do we want to turn it into a isEmpty() check which throws the PacManConfigurationException?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@avandeursen @sven4all @TimvdLippe