From e27b28c6b3ca8c9155bff38891189eb73deab611 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= Date: Mon, 20 Nov 2023 07:38:52 +0100 Subject: [PATCH] Remove incorrect dependencies from `setup.cfg` Remove the `install_requires` on `setuptools`. This key is used to specify packages that are needed at runtime. SCons nowhere in its code does import `setuptools` or `pkg_resources`. Remove the `setup_requires` on `build`. `build` is a frontend package and a detail of how the build is invoked, while `setup_requires` are used to specify backend dependencies (i.e. packages that are installed after `build` is invoked). Remove the `setup_requires` on `setuptools`. It is a key specific to setuptools, so for it to be interpreted `setuptools` need to be installed already. The actual backend dependency on `setuptools` is specified in `pyproject.toml`, so the dependency is entirely redundant. --- CHANGES.txt | 5 ++--- RELEASE.txt | 2 +- setup.cfg | 4 ---- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/CHANGES.txt b/CHANGES.txt index f45dc9647d..a55cb8f5fc 100644 --- a/CHANGES.txt +++ b/CHANGES.txt @@ -9,9 +9,8 @@ NOTE: 4.3.0 now requires Python 3.6.0 and above. Python 3.5.x is no longer suppo RELEASE VERSION/DATE TO BE FILLED IN LATER - From John Doe: - - - Whatever John Doe did. + From Michał Górny: + - Remove unecessary dependencies on pypi packages from setup.cfg RELEASE 4.6.0 - Sun, 19 Nov 2023 17:22:20 -0700 diff --git a/RELEASE.txt b/RELEASE.txt index 6bf0d09b1d..b60e758347 100644 --- a/RELEASE.txt +++ b/RELEASE.txt @@ -44,7 +44,7 @@ IMPROVEMENTS PACKAGING --------- -- List changes in the way SCons is packaged and/or released +- Remove unecessary dependencies on pypi packages from setup.cfg DOCUMENTATION ------------- diff --git a/setup.cfg b/setup.cfg index b6d7a5e567..40e24e2985 100644 --- a/setup.cfg +++ b/setup.cfg @@ -45,10 +45,6 @@ classifiers = [options] zip_safe = False python_requires = >=3.6 -install_requires = setuptools -setup_requires = - setuptools - build include_package_data = True packages = find: