Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not cleanup editor when content is not valid #907

Open
marhaupe opened this issue Mar 26, 2020 · 1 comment
Open

Do not cleanup editor when content is not valid #907

marhaupe opened this issue Mar 26, 2020 · 1 comment

Comments

@marhaupe
Copy link

marhaupe commented Mar 26, 2020 •
edited
Loading

Currently, the temporary file created by the editor prompt gets deleted whether or not the validate function returns true. Looking at the source of the external-editor module, as far as I can tell, it should be fairly easy to delay the file cleanup. Let me know if PRs are welcome for this, I'd very much like to have this functionality.
@marhaupe
Copy link
Author

marhaupe commented Apr 1, 2020

Quick Update @SBoudrias: I'm currently using my own fork where I added this functionality. Let me know what I have to do before submitting a PR. As far as I can tell, I have to change the old and the new packages, which I already did. Anything else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marhaupe