Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switches client code from JS to TS #3803

Open
wants to merge 88 commits into
base: main
Choose a base branch
from
Open

Switches client code from JS to TS #3803

wants to merge 88 commits into from

Conversation

walmazacn
Copy link
Contributor

Description

Changes proposed in this pull request:

  • switches client code from JS to TS

Related issue(s)

Resolves #3791

@walmazacn walmazacn marked this pull request as draft July 3, 2024 11:51
@walmazacn walmazacn marked this pull request as ready for review July 5, 2024 11:30
@JohannesDoberer JohannesDoberer self-assigned this Jul 8, 2024
@ndricimrr ndricimrr self-assigned this Jul 8, 2024
ndricimrr
ndricimrr reviewed Jul 8, 2024
View reviewed changes
client/luigi-client.d.ts Show resolved Hide resolved
client/luigi-client.d.ts Outdated Show resolved Hide resolved
client/luigi-client.d.ts Outdated Show resolved Hide resolved
client/luigi-element.d.ts Show resolved Hide resolved
client/src/lifecycleManager.ts Show resolved Hide resolved
client/src/lifecycleManager.ts Outdated Show resolved Hide resolved
client/src/linkManager.ts Outdated Show resolved Hide resolved
client/src/luigi-element.ts Show resolved Hide resolved
ndricimrr
ndricimrr reviewed Jul 9, 2024
View reviewed changes
test/e2e-angular.sh Outdated Show resolved Hide resolved
ndricimrr
ndricimrr reviewed Aug 21, 2024
View reviewed changes
scripts/package.json Outdated Show resolved Hide resolved
@walmazacn walmazacn added the WIP Work in progress label Aug 22, 2024
@walmazacn walmazacn removed the WIP Work in progress label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndricimrr ndricimrr ndricimrr left review comments

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

@smahati smahati Awaiting requested review from smahati smahati is a code owner

@amilewskaa amilewskaa Awaiting requested review from amilewskaa amilewskaa is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@JohannesDoberer JohannesDoberer

@ndricimrr ndricimrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch all client code from JS to Typescript
3 participants
@walmazacn @ndricimrr @JohannesDoberer