Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Operator: Basic Metrics enabled #152

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

Pavan-SAP
Copy link
Contributor

@Pavan-SAP Pavan-SAP commented Nov 5, 2024

Enable basic metrics for the operator:

  • controller: workqueue, tenant operation (optional detailed) metrics
  • subscription: http handler metrics

Note: For the controller, detailed tenant operation metrics are disabled
by default and can be enabled by setting the environment variable:
DETAILED_OPERATIONAL_METRICS to true.

Documentation will be published under:
https://sap.github.io/cap-operator/docs/usage/operator-metrics/

@Pavan-SAP Pavan-SAP force-pushed the controllerMetrics branch 2 times, most recently from d54fea9 to c6021f6 Compare November 6, 2024 15:33
@Pavan-SAP Pavan-SAP marked this pull request as ready for review November 6, 2024 15:35
@Pavan-SAP
Copy link
Contributor Author

Can be tested using:
ghcr.io/pavan-sap/cap-operator/controller:0.11.0
&
ghcr.io/pavan-sap/cap-operator/server:0.11.0

The metrics server for both is running under port 9090 (and /metrics path by default)

Copy link
Contributor

@anirudhprasad-sap anirudhprasad-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Pavan-SAP Pavan-SAP force-pushed the controllerMetrics branch 5 times, most recently from 2becabb to e88a74d Compare November 13, 2024 14:21
Enable basic metrics for the operator:
- controller: workqueue, tenant operation (optional detailed) metrics
- subscription: http handler metrics

Note: For the controller, detailed tenant operation metrics are disabled
by default and can be enabled by setting the environment variable:
`DETAILED_OPERATIONAL_METRICS` to `true`.

Documentation will be published under:
 https://sap.github.io/cap-operator/docs/usage/operator-metrics/
Copy link

sonarcloud bot commented Nov 13, 2024

Copy link
Contributor

@skrishnan-sap skrishnan-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK - tested with multiple apps.

@Pavan-SAP Pavan-SAP merged commit cce3ecd into main Nov 13, 2024
7 checks passed
@Pavan-SAP Pavan-SAP deleted the controllerMetrics branch November 13, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants