Fixes

SAML-Toolkits · Jul 10, 2024 · 1d89633 · 1d89633
1 parent 8214ee5
commit 1d89633
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/test/logoutrequest_test.rb b/test/logoutrequest_test.rb
@@ -185,8 +185,7 @@ class RequestTest < Minitest::Test
         end
 
         it "create a signed logout request with SHA512 digest and signature method RSA_SHA384" do
-          # SHA384/SHA512 not supported by DSA
-          skip if algorithm == :dsa
+          skip('DSA does not support SHA384/SHA512') if algorithm == :dsa
 
           # RSA is ignored here; only the hash algorithm is used
           settings.security[:signature_method] = RubySaml::XML::Document::RSA_SHA384

diff --git a/test/slo_logoutresponse_test.rb b/test/slo_logoutresponse_test.rb
@@ -163,8 +163,7 @@ class SloLogoutresponseTest < Minitest::Test
         end
 
         it "create a signed logout response with SHA384 digest and signature method RSA_SHA512" do
-          # SHA384/SHA512 not supported by DSA
-          skip if algorithm == :dsa
+          skip('DSA does not support SHA384/SHA512') if algorithm == :dsa
 
           # RSA is ignored here; only the hash algorithm is used
           settings.security[:signature_method] = RubySaml::XML::Document::RSA_SHA512
@@ -180,8 +179,7 @@ class SloLogoutresponseTest < Minitest::Test
         end
 
         it "create a signed logout response with SHA512 digest and signature method RSA_SHA384" do
-          # SHA384/SHA512 not supported by DSA
-          skip if algorithm == :dsa
+          skip('DSA does not support SHA384/SHA512') if algorithm == :dsa
 
           # RSA is ignored here; only the hash algorithm is used
           settings.security[:signature_method] = RubySaml::XML::Document::RSA_SHA384

diff --git a/test/utils_test.rb b/test/utils_test.rb
@@ -344,8 +344,8 @@ def result(duration, reference = 0)
 
   describe '.decrypt_multi' do
     let(:private_key) { ruby_saml_key }
-    let(:invalid_key1) { CertificateHelper.generate_key }
-    let(:invalid_key2) { CertificateHelper.generate_key }
+    let(:invalid_key1) { CertificateHelper.generate_private_key }
+    let(:invalid_key2) { CertificateHelper.generate_private_key }
     let(:settings) { RubySaml::Settings.new(:private_key => private_key.to_pem) }
     let(:response) { RubySaml::Response.new(signed_message_encrypted_unsigned_assertion, :settings => settings) }
     let(:encrypted) do