Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix execute strategy and add try except #15

Open
wants to merge 2 commits into
base: students
Choose a base branch
from

Conversation

qimolin
Copy link
Contributor

@qimolin qimolin commented Nov 29, 2023

Reason for pull request

After discussion with the TA about the execute strategy, we came to the conclusion that the strategy in UPISAS is incorrect.

Current behavior

It checks the adaptation_options input against the execute schema while we expect the input to be the adaptation from the adaptation endpoint.

Expected behavior

  • Check adaptation input against adaptation_options_schema (not required because you would have to call the adaptation_options_schema first in the test)
  • Make a put request to execute with the adaptation_options
  • Check the response from the request against the execute_schema

Additionally

Added try except in _start_server_and_wait_until_is_up to make sure it retries connection to the server after failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant