Missing formats #1
Comments
|
#3 will also require a PKCS#7 implementation so I'll start work on that as well. I've created PKCS#7 support #28 to track. |
|
Do you want to stick to the big ones or are you also interested in things like the "TLS codec". It's not really a standard but it's being used quite a bit by now. I have a version here https://github.com/openmls/tls-codec/ |
|
@franziskuskiefer if you so happen to be looking for another home for it I'd say that would be a great thing to have here |
|
The new |
|
@jonasbb yes, it would be good to add support for those. Likewise it would be nice to have support for OpenSSH certificates. I will try to get these items added to the TODO list in the README, or otherwise would merge a PR to add them. |
The naming of the `to_owned` method was a bit unfortunate as it
triggered conflicts with the `alloc::borrow::ToOwned` method. When used,
this would make for compiler messages asking things like:
```
error[E0034]: multiple applicable items in scope
--> certval/src/validator/name_constraints_set.rs:748:34
|
748 | value: a.to_owned(),
| ^^^^^^^^ multiple `to_owned` found
|
= note: candidate RustCrypto#1 is defined in an impl of the trait `RefToOwned` for the type `AnyRef<'a>`
= note: candidate RustCrypto#2 is defined in an impl of the trait `ToOwned` for the type `T`
help: disambiguate the associated function for candidate RustCrypto#1
|
748 | value: RefToOwned::to_owned(&a),
| ~~~~~~~~~~~~~~~~~~~~~~~~
help: disambiguate the associated function for candidate RustCrypto#2
|
748 | value: ToOwned::to_owned(&a),
| ~~~~~~~~~~~~~~~~~~~~~
```
The naming of the `to_owned` method was a bit unfortunate as it
triggered conflicts with the `alloc::borrow::ToOwned` method. When used,
this would make for compiler messages asking things like:
```
error[E0034]: multiple applicable items in scope
--> certval/src/validator/name_constraints_set.rs:748:34
|
748 | value: a.to_owned(),
| ^^^^^^^^ multiple `to_owned` found
|
= note: candidate #1 is defined in an impl of the trait `RefToOwned` for the type `AnyRef<'a>`
= note: candidate #2 is defined in an impl of the trait `ToOwned` for the type `T`
help: disambiguate the associated function for candidate #1
|
748 | value: RefToOwned::to_owned(&a),
| ~~~~~~~~~~~~~~~~~~~~~~~~
help: disambiguate the associated function for candidate #2
|
748 | value: ToOwned::to_owned(&a),
| ~~~~~~~~~~~~~~~~~~~~~
```
|
Do you think RFC3161 TimeStamp Protocol would be a good addition to the formats? reference: https://www.rfc-editor.org/rfc/rfc3161 |
|
I think RFC3161 would be a good addition and have thought about implementing it before but had not gotten around to it. It's referenced in some new work, for example, draft-birkholz-rats-epoch-markers. |
|
I'd like to help, can I just open a PR once I've got some basic implementation of the structures? Maybe a new folder under formats/tsp? |
|
We'd need a crate name we actually control, although you can use that name temporarily until we pick one we do control |
|
I would potentially be interested in contributing an implementation of RFC5544. Is that something the project would benefit from? |
|
Hey @leotaku I've actually created an issue for this format and I have most of the work done locally, the blocking issue for me is that I get an indefinite length error which seems to come from a BER/DER mixed encoding. #1198 I was waiting to get some feedback, but I could definitely open a PR for you to test for your self, maybe you can spot something i missed. |
|
@enri1196 That sounds great. If you open a PR or direct me to your fork I'd love to take a look. |
|
PKCS#15 |
cms: use aes-kw pre-release
Please post a comment to request additional formats
The text was updated successfully, but these errors were encountered: