Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aes-gcm-siv: outdated aes and cipher #410

Closed
tomtau opened this issue Apr 6, 2022 · 7 comments
Closed

aes-gcm-siv: outdated aes and cipher #410

tomtau opened this issue Apr 6, 2022 · 7 comments

Comments

@tomtau
Copy link

tomtau commented Apr 6, 2022

good to bump the crate versions (as in #409 for aes-gcm)
@tarcieri
Copy link
Member

tarcieri commented Apr 6, 2022

Will get to this soon. Recently updated aes-gcm and chacha20poly1305.

@rozbb
Copy link

rozbb commented Apr 26, 2022 •
edited
Loading

I began an attempt at this and encountered a problem: ParBlocksSizeUser is not implemented for Aes128. In fact, ParBlocksSizeUser is only implemented for hidden backend types throughout the AEADs repo. I think this has to change before anything else happens. Importantly, I think this change is also a blocker to fixing #74.

Once that's fixed, my branch here should be mergeable. You can see where it fails now by cargo test.

@tarcieri
Copy link
Member

@rozbb I've already done aes-gcm. It's a fairly straightforward upgrade

@rozbb
Copy link

rozbb commented Apr 26, 2022 via email

@tarcieri
Copy link
Member

You're right, that is different

@rozbb rozbb mentioned this issue Apr 29, 2022
Closed
@rozbb
Copy link

rozbb commented Apr 29, 2022

See above PR. I have a branch that successfully updates the dependencies of aes-gcm-siv. Just need a new version of block-ciphers.

@tarcieri tarcieri mentioned this issue May 1, 2022
Closed
bunnie added a commit to betrusted-io/xous-core that referenced this issue May 29, 2022
@bunnie
add ParBlocks type to our AES implementation
596cebc 
see RustCrypto/AEADs#410
bunnie added a commit to betrusted-io/xous-core that referenced this issue May 29, 2022
@bunnie
work around RustCrypto/AEADs#410
1946d38 
We're trying to bring the AES version up so we can do CBC
(required for FIDO2) but unfortunately the aes-gcm-siv crate
is locked to an outdated version of AES, and this is blocking
on a type that is missing in the `block-ciphers` crate.

For now, we're using a patched version of aes-gcm-siv from
rozbb's repo, which allows us to move forward, but this needs
to be reverted once a new version of the official crate is patched.
@bunnie bunnie mentioned this issue May 29, 2022
Closed
nworbnhoj pushed a commit to nworbnhoj/xous-core that referenced this issue Jun 1, 2022
@bunnie @nworbnhoj
add ParBlocks type to our AES implementation
b0ee0ce 
see RustCrypto/AEADs#410
nworbnhoj pushed a commit to nworbnhoj/xous-core that referenced this issue Jun 1, 2022
@bunnie @nworbnhoj
work around RustCrypto/AEADs#410
95784b6 
We're trying to bring the AES version up so we can do CBC
(required for FIDO2) but unfortunately the aes-gcm-siv crate
is locked to an outdated version of AES, and this is blocking
on a type that is missing in the `block-ciphers` crate.

For now, we're using a patched version of aes-gcm-siv from
rozbb's repo, which allows us to move forward, but this needs
to be reverted once a new version of the official crate is patched.
@tomtau
Copy link
Author

tomtau commented Aug 3, 2022

it seems fixed in 0.11 #464

@tomtau tomtau closed this as completed Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tarcieri @rozbb @tomtau