Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove field access from EmptyCallback #615

Open
dvdsk opened this issue Sep 16, 2024 · 0 comments
Open

Remove field access from EmptyCallback #615

dvdsk opened this issue Sep 16, 2024 · 0 comments
Labels
breaking Proposed change that would break the public API

Comments

@dvdsk
Copy link
Collaborator

dvdsk commented Sep 16, 2024

There is no reason why this:

rodio/src/source/empty_callback.rs

Line 10 in 70c236c

pub phantom_data: PhantomData<S>,

is public. Same for the callback. The struct should only be made by the factory function EmptyCallback::new.
@dvdsk dvdsk added the breaking Proposed change that would break the public API label Sep 16, 2024
@dvdsk dvdsk mentioned this issue Sep 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Proposed change that would break the public API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dvdsk