From a9e89e42e775b52ea865470b5338dfe292d4fc28 Mon Sep 17 00:00:00 2001
From: bernhard <Bernhard.Schmalhofer@gmx.de>
Date: Fri, 18 Mar 2022 19:26:16 +0100
Subject: [PATCH 1/4] Issue #7: migrated to Test2::V0, use
 Kernel::System::UnitTest::MockTime

Do not reuse the variable @Tests
---
 scripts/test/FAQSearch.t | 150 ++++++++++++---------------------------
 1 file changed, 46 insertions(+), 104 deletions(-)

diff --git a/scripts/test/FAQSearch.t b/scripts/test/FAQSearch.t
index 70bc41e..8ecdc39 100644
--- a/scripts/test/FAQSearch.t
+++ b/scripts/test/FAQSearch.t
@@ -21,11 +21,11 @@ use warnings;
 # core modules
 
 # CPAN modules
+use Test2::V0;
 
 # OTOBO modules
-use Kernel::System::UnitTest::RegisterDriver;    # Set up $Self and $Kernel::OM
-
-our $Self;
+use Kernel::System::UnitTest::RegisterDriver;    # Set up $Kernel::OM
+use Kernel::System::UnitTest::MockTime qw(:all);
 
 # get helper object
 $Kernel::OM->ObjectParamAdd(
@@ -72,7 +72,8 @@ my %FAQAddTemplate = (
 );
 
 # freeze time
-$Helper->FixedTimeSet();
+FixedTimeSet(); # t=0m
+FixedTimeAddSeconds(10*60);
 
 # get FAQ object
 my $FAQObject = $Kernel::OM->Get('Kernel::System::FAQ');
@@ -83,17 +84,12 @@ for my $Counter ( 1 .. 2 ) {
         UserID => $AddedUsers[ $Counter - 1 ],
     );
 
-    $Self->IsNot(
-        undef,
-        $ItemID,
-        "FAQAdd() ItemID:'$ItemID' for FAQSearch()",
-    );
-
+    ok( defined $ItemID, "FAQAdd() $Counter ItemID:'$ItemID' for FAQSearch()",);
     push @AddedFAQs, $ItemID;
 
     # add 1 minute to frozen time
-    $Helper->FixedTimeAddSeconds(60);
-}
+    FixedTimeAddSeconds(60);
+} # t=2m
 
 # add some votes
 my @VotesToAdd = (
@@ -142,15 +138,12 @@ my @VotesToAdd = (
 for my $Vote (@VotesToAdd) {
     my $Success = $FAQObject->VoteAdd( %{$Vote} );
 
-    $Self->True(
-        $Success,
-        "VoteAdd(): ItemID:'$Vote->{ItemID}' IP:'$Vote->{IP}' Rate:'$Vote->{Rate}' with true",
-    );
+    ok( $Success, "VoteAdd(): ItemID:'$Vote->{ItemID}' IP:'$Vote->{IP}' Rate:'$Vote->{Rate}' with true" );
 }
 
 # do vote search tests
 my %SearchConfigTemplate = (
-    Keyword          => "$RandomID",
+    Keyword          => $RandomID,
     States           => [ 'public', 'internal' ],
     OrderBy          => ['FAQID'],
     OrderByDirection => ['Up'],
@@ -158,7 +151,7 @@ my %SearchConfigTemplate = (
     UserID           => 1,
 
 );
-my @Tests = (
+my @VotesTests = (
 
     # votes tests
     {
@@ -490,18 +483,14 @@ my @Tests = (
 );
 
 # execute the tests
-for my $Test (@Tests) {
+for my $Test (@VotesTests) {
     my @ItemIDs = $FAQObject->FAQSearch( %{ $Test->{Config} } );
 
-    $Self->IsDeeply(
-        \@ItemIDs,
-        $Test->{ExpectedResults},
-        "$Test->{Name} FAQSearch()",
-    );
+    is( \@ItemIDs, $Test->{ExpectedResults}, "$Test->{Name} FAQSearch()" );
 }
 
 # other tests
-@Tests = (
+my @OtherTests = (
     {
         Name   => 'States Hash Correct IDs',
         Config => {
@@ -542,14 +531,10 @@ for my $Test (@Tests) {
 );
 
 # execute the tests
-for my $Test (@Tests) {
+for my $Test (@OtherTests) {
     my @ItemIDs = $FAQObject->FAQSearch( %{ $Test->{Config} } );
 
-    $Self->IsDeeply(
-        \@ItemIDs,
-        $Test->{ExpectedResults},
-        "$Test->{Name} FAQSearch()",
-    );
+    is( \@ItemIDs, $Test->{ExpectedResults}, "$Test->{Name} FAQSearch()" );
 }
 
 # time based tests
@@ -568,7 +553,7 @@ my %FAQUpdateTemplate = (
 );
 
 # add 1 minute to frozen time
-$Helper->FixedTimeAddSeconds(60);
+FixedTimeAddSeconds(60); # t=3m
 
 my $Success = $FAQObject->FAQUpdate(
     %FAQUpdateTemplate,
@@ -576,12 +561,9 @@ my $Success = $FAQObject->FAQUpdate(
     UserID => $AddedUsers[2],
 );
 
-$Self->True(
-    $Success,
-    "FAQUpdate() ItemID:'$AddedFAQs[0]' for FAQSearch()",
-);
+ok( $Success, "FAQUpdate() ItemID:'$AddedFAQs[0]' for FAQSearch()" );
 
-$Helper->FixedTimeAddSeconds(60);
+FixedTimeAddSeconds(60); # t=4m
 
 $Success = $FAQObject->FAQUpdate(
     %FAQUpdateTemplate,
@@ -589,13 +571,10 @@ $Success = $FAQObject->FAQUpdate(
     UserID => $AddedUsers[3],
 );
 
-$Self->True(
-    $Success,
-    "FAQUpdate() ItemID:'$AddedFAQs[1]' for FAQSearch()",
-);
+ok( $Success, "FAQUpdate() ItemID:'$AddedFAQs[1]' for FAQSearch()" );
 
 # add 2 minutes to frozen time
-$Helper->FixedTimeAddSeconds(120);
+FixedTimeAddSeconds(120); # t=6m
 
 my $DateTime = $Kernel::OM->Create('Kernel::System::DateTime');
 
@@ -611,7 +590,8 @@ my $DateMinus5Mins = $DateTime->ToString();
 $DateTime->Subtract( Seconds => 60 );
 my $DateMinus6Mins = $DateTime->ToString();
 
-@Tests = (
+# Two FAQs were added. One 6 minutes ago, the other 5 minutes ago
+my @TimeBasedTests = (
     {
         Name   => 'CreateTimeOlderMinutes 3 min',
         Config => {
@@ -728,19 +708,14 @@ my $DateMinus6Mins = $DateTime->ToString();
 );
 
 # execute the tests
-for my $Test (@Tests) {
-
+for my $Test (@TimeBasedTests) {
     my @ItemIDs = $FAQObject->FAQSearch( %{ $Test->{Config} } );
 
-    $Self->IsDeeply(
-        \@ItemIDs,
-        $Test->{ExpectedResults},
-        "$Test->{Name} FAQSearch()",
-    );
+    is( \@ItemIDs, $Test->{ExpectedResults}, "$Test->{Name} FAQSearch()" );
 }
 
 # created user tests
-@Tests = (
+my @CreatedUserTests = (
     {
         Name   => 'CreatedUserIDs 1',
         Config => {
@@ -786,7 +761,7 @@ for my $Test (@Tests) {
 );
 
 # last changed user tests
-@Tests = (
+my @LastChangedUserTests = (
     {
         Name   => 'LastChangedUserIDs 3',
         Config => {
@@ -829,15 +804,10 @@ for my $Test (@Tests) {
 );
 
 # execute the tests
-for my $Test (@Tests) {
-
+for my $Test (@LastChangedUserTests) {
     my @ItemIDs = $FAQObject->FAQSearch( %{ $Test->{Config} } );
 
-    $Self->IsDeeply(
-        \@ItemIDs,
-        $Test->{ExpectedResults},
-        "$Test->{Name} FAQSearch()",
-    );
+    is( \@ItemIDs, $Test->{ExpectedResults}, "$Test->{Name} FAQSearch()" );
 }
 
 # approval tests
@@ -853,7 +823,7 @@ return if !$Kernel::OM->Get('Kernel::System::DB')->Do(
     ],
 );
 
-@Tests = (
+my @ApprovalTests = (
     {
         Name   => 'Approved 1',
         Config => {
@@ -877,22 +847,14 @@ return if !$Kernel::OM->Get('Kernel::System::DB')->Do(
 );
 
 # execute the tests
-for my $Test (@Tests) {
-
+for my $Test (@ApprovalTests) {
     my @ItemIDs = $FAQObject->FAQSearch( %{ $Test->{Config} } );
 
-    $Self->IsDeeply(
-        \@ItemIDs,
-        $Test->{ExpectedResults},
-        "$Test->{Name} FAQSearch()",
-    );
+    is( \@ItemIDs, $Test->{ExpectedResults}, "$Test->{Name} FAQSearch()" );
 }
 
 # execute old tests
-$Self->True(
-    1,
-    "--Execute Former Tests--",
-);
+diag( "Execute Former Tests" );
 {
     my $ItemID1 = $FAQObject->FAQAdd(
         CategoryID  => 1,
@@ -906,13 +868,10 @@ $Self->True(
         UserID      => 1,
         ContentType => 'text/html',
     );
-    $Self->True(
-        $ItemID1,
-        "FAQAdd() - 1",
-    );
+    ok( $ItemID1, "FAQAdd() - 1" );
 
     # add 1 minute to frozen time
-    $Helper->FixedTimeAddSeconds(60);
+    FixedTimeAddSeconds(60); # t=7m
 
     my $ItemID2 = $FAQObject->FAQAdd(
         Title       => 'Title' . $RandomID,
@@ -925,13 +884,10 @@ $Self->True(
         UserID      => 1,
         ContentType => 'text/html',
     );
-    $Self->True(
-        $ItemID2,
-        "FAQAdd() - 2",
-    );
+    ok( $ItemID2, "FAQAdd() - 2");
 
     # add 1 minute to frozen time
-    $Helper->FixedTimeAddSeconds(60);
+    FixedTimeAddSeconds(60);# t=8m
 
     my %Keywords = (
         Keyword1 => "some1$RandomID",
@@ -950,13 +906,10 @@ $Self->True(
         UserID      => 1,
         ContentType => 'text/html',
     );
-    $Self->True(
-        $ItemID3,
-        "FAQAdd() - 3",
-    );
+    ok( $ItemID3, "FAQAdd() - 3");
 
     # add 1 minute to frozen time
-    $Helper->FixedTimeAddSeconds(60);
+    FixedTimeAddSeconds(60); # t=9m
 
     my $ItemID4 = $FAQObject->FAQAdd(
         Title      => 'Test FAQ-4',
@@ -969,13 +922,10 @@ $Self->True(
         ContentType => 'text/html',
     );
 
-    $Self->True(
-        $ItemID4,
-        "FAQAdd() - 4",
-    );
+    ok( $ItemID4, "FAQAdd() - 4");
 
     # add 1 minute to frozen time
-    $Helper->FixedTimeAddSeconds(60);
+    FixedTimeAddSeconds(60); # t=10m
 
     my $ItemID5 = $FAQObject->FAQAdd(
         Title      => 'Test FAQ-5',
@@ -988,15 +938,12 @@ $Self->True(
         ContentType => 'text/html',
     );
 
-    $Self->True(
-        $ItemID5,
-        "FAQAdd() - 4",
-    );
+    ok( $ItemID5, "FAQAdd() - 4");
 
     # restore time
-    $Helper->FixedTimeUnset();
+    FixedTimeUnset();
 
-    @Tests = (
+    my @Tests = (
         {
             Name   => 'Keywords',
             Config => {
@@ -1172,7 +1119,6 @@ $Self->True(
     );
 
     for my $Test (@Tests) {
-
         my @ItemIDs = $FAQObject->FAQSearch(
             Number           => '*',
             States           => [ 'public', 'internal' ],
@@ -1182,12 +1128,8 @@ $Self->True(
             %{ $Test->{Config} },
         );
 
-        $Self->IsDeeply(
-            \@ItemIDs,
-            $Test->{ExpectedResults},
-            "$Test->{Name}, FAQSearch()",
-        );
+        is( \@ItemIDs, $Test->{ExpectedResults}, "$Test->{Name}, FAQSearch()");
     }
 }
 
-$Self->DoneTesting();
+done_testing();

From fba18f288a4c5e981d5f7535b14654e5aa6434c5 Mon Sep 17 00:00:00 2001
From: bernhard <Bernhard.Schmalhofer@gmx.de>
Date: Fri, 18 Mar 2022 19:29:48 +0100
Subject: [PATCH 2/4] Issue #7: accept suggestions from the CodePolicy

---
 scripts/test/FAQSearch.t | 33 ++++++++++++++++-----------------
 1 file changed, 16 insertions(+), 17 deletions(-)

diff --git a/scripts/test/FAQSearch.t b/scripts/test/FAQSearch.t
index 8ecdc39..c27ffc5 100644
--- a/scripts/test/FAQSearch.t
+++ b/scripts/test/FAQSearch.t
@@ -72,8 +72,7 @@ my %FAQAddTemplate = (
 );
 
 # freeze time
-FixedTimeSet(); # t=0m
-FixedTimeAddSeconds(10*60);
+FixedTimeSet();    # t=0m
 
 # get FAQ object
 my $FAQObject = $Kernel::OM->Get('Kernel::System::FAQ');
@@ -84,12 +83,12 @@ for my $Counter ( 1 .. 2 ) {
         UserID => $AddedUsers[ $Counter - 1 ],
     );
 
-    ok( defined $ItemID, "FAQAdd() $Counter ItemID:'$ItemID' for FAQSearch()",);
+    ok( defined $ItemID, "FAQAdd() $Counter ItemID:'$ItemID' for FAQSearch()", );
     push @AddedFAQs, $ItemID;
 
     # add 1 minute to frozen time
     FixedTimeAddSeconds(60);
-} # t=2m
+}    # t=2m
 
 # add some votes
 my @VotesToAdd = (
@@ -553,7 +552,7 @@ my %FAQUpdateTemplate = (
 );
 
 # add 1 minute to frozen time
-FixedTimeAddSeconds(60); # t=3m
+FixedTimeAddSeconds(60);    # t=3m
 
 my $Success = $FAQObject->FAQUpdate(
     %FAQUpdateTemplate,
@@ -563,7 +562,7 @@ my $Success = $FAQObject->FAQUpdate(
 
 ok( $Success, "FAQUpdate() ItemID:'$AddedFAQs[0]' for FAQSearch()" );
 
-FixedTimeAddSeconds(60); # t=4m
+FixedTimeAddSeconds(60);    # t=4m
 
 $Success = $FAQObject->FAQUpdate(
     %FAQUpdateTemplate,
@@ -574,7 +573,7 @@ $Success = $FAQObject->FAQUpdate(
 ok( $Success, "FAQUpdate() ItemID:'$AddedFAQs[1]' for FAQSearch()" );
 
 # add 2 minutes to frozen time
-FixedTimeAddSeconds(120); # t=6m
+FixedTimeAddSeconds(120);    # t=6m
 
 my $DateTime = $Kernel::OM->Create('Kernel::System::DateTime');
 
@@ -854,7 +853,7 @@ for my $Test (@ApprovalTests) {
 }
 
 # execute old tests
-diag( "Execute Former Tests" );
+diag("Execute Former Tests");
 {
     my $ItemID1 = $FAQObject->FAQAdd(
         CategoryID  => 1,
@@ -871,7 +870,7 @@ diag( "Execute Former Tests" );
     ok( $ItemID1, "FAQAdd() - 1" );
 
     # add 1 minute to frozen time
-    FixedTimeAddSeconds(60); # t=7m
+    FixedTimeAddSeconds(60);    # t=7m
 
     my $ItemID2 = $FAQObject->FAQAdd(
         Title       => 'Title' . $RandomID,
@@ -884,10 +883,10 @@ diag( "Execute Former Tests" );
         UserID      => 1,
         ContentType => 'text/html',
     );
-    ok( $ItemID2, "FAQAdd() - 2");
+    ok( $ItemID2, "FAQAdd() - 2" );
 
     # add 1 minute to frozen time
-    FixedTimeAddSeconds(60);# t=8m
+    FixedTimeAddSeconds(60);    # t=8m
 
     my %Keywords = (
         Keyword1 => "some1$RandomID",
@@ -906,10 +905,10 @@ diag( "Execute Former Tests" );
         UserID      => 1,
         ContentType => 'text/html',
     );
-    ok( $ItemID3, "FAQAdd() - 3");
+    ok( $ItemID3, "FAQAdd() - 3" );
 
     # add 1 minute to frozen time
-    FixedTimeAddSeconds(60); # t=9m
+    FixedTimeAddSeconds(60);    # t=9m
 
     my $ItemID4 = $FAQObject->FAQAdd(
         Title      => 'Test FAQ-4',
@@ -922,10 +921,10 @@ diag( "Execute Former Tests" );
         ContentType => 'text/html',
     );
 
-    ok( $ItemID4, "FAQAdd() - 4");
+    ok( $ItemID4, "FAQAdd() - 4" );
 
     # add 1 minute to frozen time
-    FixedTimeAddSeconds(60); # t=10m
+    FixedTimeAddSeconds(60);    # t=10m
 
     my $ItemID5 = $FAQObject->FAQAdd(
         Title      => 'Test FAQ-5',
@@ -938,7 +937,7 @@ diag( "Execute Former Tests" );
         ContentType => 'text/html',
     );
 
-    ok( $ItemID5, "FAQAdd() - 4");
+    ok( $ItemID5, "FAQAdd() - 4" );
 
     # restore time
     FixedTimeUnset();
@@ -1128,7 +1127,7 @@ diag( "Execute Former Tests" );
             %{ $Test->{Config} },
         );
 
-        is( \@ItemIDs, $Test->{ExpectedResults}, "$Test->{Name}, FAQSearch()");
+        is( \@ItemIDs, $Test->{ExpectedResults}, "$Test->{Name}, FAQSearch()" );
     }
 }
 

From 425c85a2e235ca3645a5c7f7a08bce4d14a68b9b Mon Sep 17 00:00:00 2001
From: bernhard <Bernhard.Schmalhofer@gmx.de>
Date: Fri, 18 Mar 2022 19:30:56 +0100
Subject: [PATCH 3/4] Issue #7: accept suggestions from the CodePolicy

---
 scripts/test/FAQSearch.t | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/scripts/test/FAQSearch.t b/scripts/test/FAQSearch.t
index c27ffc5..858486f 100644
--- a/scripts/test/FAQSearch.t
+++ b/scripts/test/FAQSearch.t
@@ -28,11 +28,11 @@ use Kernel::System::UnitTest::RegisterDriver;    # Set up $Kernel::OM
 use Kernel::System::UnitTest::MockTime qw(:all);
 
 # get helper object
-$Kernel::OM->ObjectParamAdd(
-    'Kernel::System::UnitTest::Helper' => {
-        RestoreDatabase => 1,
-    },
-);
+#$Kernel::OM->ObjectParamAdd(
+#    'Kernel::System::UnitTest::Helper' => {
+#        RestoreDatabase => 1,
+#    },
+#);
 my $Helper = $Kernel::OM->Get('Kernel::System::UnitTest::Helper');
 
 # set config options
@@ -65,7 +65,6 @@ my %FAQAddTemplate = (
     StateID     => 1,
     LanguageID  => 1,
     Keywords    => $RandomID,
-    Field1      => 'Problem...',
     Field2      => 'Solution...',
     UserID      => 1,
     ContentType => 'text/html',
@@ -77,10 +76,14 @@ FixedTimeSet();    # t=0m
 # get FAQ object
 my $FAQObject = $Kernel::OM->Get('Kernel::System::FAQ');
 
+# add two FAQs with creation time 60 s apart
+my @Field1;
 for my $Counter ( 1 .. 2 ) {
+    push @Field1, sprintf 'Field1 Counter: %d, time: %d', $Counter, time;
     my $ItemID = $FAQObject->FAQAdd(
         %FAQAddTemplate,
         UserID => $AddedUsers[ $Counter - 1 ],
+        Field1 => $Field1[-1],
     );
 
     ok( defined $ItemID, "FAQAdd() $Counter ItemID:'$ItemID' for FAQSearch()", );
@@ -545,7 +548,6 @@ my %FAQUpdateTemplate = (
     StateID     => 1,
     LanguageID  => 1,
     Keywords    => $RandomID,
-    Field1      => 'Problem...',
     Field2      => 'Solution...',
     UserID      => 1,
     ContentType => 'text/html',
@@ -557,6 +559,7 @@ FixedTimeAddSeconds(60);    # t=3m
 my $Success = $FAQObject->FAQUpdate(
     %FAQUpdateTemplate,
     ItemID => $AddedFAQs[0],
+    Field1 => "Updated $Field1[0]",
     UserID => $AddedUsers[2],
 );
 
@@ -567,6 +570,7 @@ FixedTimeAddSeconds(60);    # t=4m
 $Success = $FAQObject->FAQUpdate(
     %FAQUpdateTemplate,
     ItemID => $AddedFAQs[1],
+    Field1 => "Updated $Field1[1]",
     UserID => $AddedUsers[3],
 );
 

From 88b79a7d3b41da75b4b475c67700dc057d1acfca Mon Sep 17 00:00:00 2001
From: bernhard <Bernhard.Schmalhofer@gmx.de>
Date: Fri, 18 Mar 2022 19:31:38 +0100
Subject: [PATCH 4/4] Issue #7: one batch of tests was not executed

---
 scripts/test/FAQSearch.t | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/scripts/test/FAQSearch.t b/scripts/test/FAQSearch.t
index 858486f..62fb56b 100644
--- a/scripts/test/FAQSearch.t
+++ b/scripts/test/FAQSearch.t
@@ -763,6 +763,13 @@ my @CreatedUserTests = (
     },
 );
 
+# execute the tests
+for my $Test (@CreatedUserTests) {
+    my @ItemIDs = $FAQObject->FAQSearch( %{ $Test->{Config} } );
+
+    is( \@ItemIDs, $Test->{ExpectedResults}, "$Test->{Name} FAQSearch()" );
+}
+
 # last changed user tests
 my @LastChangedUserTests = (
     {