Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix personal_sign generates wrong signature #95

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix personal_sign generates wrong signature #95

wants to merge 2 commits into from

Conversation

HaoCherHong
Copy link
Contributor

@HaoCherHong HaoCherHong commented Jan 11, 2023 •
edited
Loading

According to this walletconnect protocal doc, correct order of params is [message, address] instead of [address, message]. And there is no password parameter.

This error only occurs in certain wallet app because some apps like MetaMask and ImToken handles the params in both order.

Close #80

Changes

fix personal_sign params order

@HaoCherHong HaoCherHong mentioned this pull request Jan 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rainbow Wallet, Trust Wallet personal_sign not displaying signing message
1 participant
@HaoCherHong