Replies: 4 comments 41 replies
-
|
You have a loop running. The timer 0 never stops since you set counter1 back to 1 when you have set it to 2. SInce you have the same sysex message in both timers I don't understand your script. end -- f SendSysexTwiceOnDbleClick_1_0_0_2022-03-07_04-52.panel.zip Can you please explain precisely what you want to achieve? |
Beta Was this translation helpful? Give feedback.
-
|
@damiensellier The code you proposed with the counter is exactly what I meant as answer to another post ;-) |
Beta Was this translation helpful? Give feedback.
-
|
I don't know if it worked for @DRBAUS but this is actually the only way to do it. with the Lookup table that will do something like that : |
Beta Was this translation helpful? Give feedback.
-
|
Lovely! Great Damien! |
Beta Was this translation helpful? Give feedback.
-
|
Okay, could you please check the attached panel? Your provided code is working! I changed the Id of the Timer to 0 and the name of the counter to counter0. Still works. Then I copied the uiLabel, created another script called myMethod2, copied the code and changed the name counter0 to counter1 as well as timer Id 0 to Id1. I did the same for the TimerCallback. Created a TimerCallback1, copied the code from TimerCallback and changed counter0 to counter1 and timerId from 0 to 1. Double click on that one only shows the following in console:
and the rest of the script is not running. |
Beta Was this translation helpful? Give feedback.
-
|
@DRBAUS you need just one TimerCallback() method for your panel. just call the different timers by their ids. it would have been : just put all your timers in the same method or you will get lost. check the following panel I revised it. SendSysexTwiceOnDbleClick_1_1_0_2022-03-08_14-19.panel.zip Also check the streamlined version of the panel I posted yesterday using tables to remove those 32 redundant "if". |
Beta Was this translation helpful? Give feedback.
-
|
Thanks guys.
I am have not been able to test it further today because of work. Will do
as soon as possible.
I think I noticed where it went wrong though.
Will update as soon as I can.
Op ma 7 mrt. 2022 22:05 schreef Damien S. ***@***.***>:
… I don't know if it worked for @DRBAUS <https://github.com/DRBAUS> but
this is actually the only way to do it.
You can streamline the process with a table and iteration to remove
everything redundant lines if ever there's just 1 byte in the message
changing for the different parameters (1 to 16) to reset to 0. If they are
not the same number as the counter number, we can crossmatch it with a
lookuptable and use counter as K to to table in pair.
TimerCallback = function(timerId)
if timerId == 0 then
if counter1 < 16 then
console("counter1 : "..(counter1))
panel:sendMidiMessageNow(CtrlrMidiMessage({0xF0, 0x0F, 0x03, 0x00, 0x11, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x04, 0x03, 0x00, 0x00, 0x00, counter1, 0xF7}))
counter1 = counter1 + 1
else
timer:stopTimer(0)
end
end -- end timer #0
end -- f
—
Reply to this email directly, view it on GitHub
<#442 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASNL6ILOZ6ZMWFWECA6UNQLU6ZVQFANCNFSM5QCVPUPQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
Here is a working panel with lookup table to the modulators number relative to the counter as "k" in table, if needed: I highly recommand to use the message as MemoryBlock to avoid errors in newer version of Ctrlr with sendMidiMessageNow : |
Beta Was this translation helpful? Give feedback.
-
|
Hi Damien! It's a very nice example and helped my understanding of timers yet again. 🤢 I sometimes have trouble understanding them. There are a couple of changes I would suggest though: 😁 TimerCallback = function(timerId)
if timerId == 0 then
if counter1 < 16 then
console("counter1 : " .. (counter1))
local tableMod = {2, 6, 3, 18, 27, 4, 3, 6, 8, 6, 1, 5, 9, 15, 14, 21}
for k, v in pairs(tableMod) do
tableModValue = tableMod[counter1]
end
console("tablemod value : " .. tableModValue)
panel:sendMidiMessageNow(
CtrlrMidiMessage(
MemoryBlock(
{
0xF0,
0x0F,
0x03,
0x00,
0x11,
0x00,
0x00,
0x00,
0x00,
0x00,
0x01,
0x04,
0x03,
0x00,
0x00,
0x00,
tableModValue,
0xF7
}
)
)
)
counter1 = counter1 + 1
else
timer:stopTimer(0)
end
end -- end timer #0
end -- f
I think the loop (which should probably be ipairs not pairs) is unnecessary in that timer. Also I think it's better to keep this table somewhere separate to the timer code otherwise the table is being recreated on each iteration of the timer. tableMod = {2,6,3,18,27,4,3,6,8,6,1,5,9,15,14,21} -- make this global in its own file
or another suggestion for the Timer code: TimerCallback = function(timerId)
if timerId == 0 then
if counter1 == #tableMod then
timer:stopTimer(timerId)
else
console("counter1 : " .. counter1)
panel:sendMidiMessageNow(
CtrlrMidiMessage(
MemoryBlock(
{
0xF0,
0x0F,
0x03,
0x00,
0x11,
0x00,
0x00,
0x00,
0x00,
0x00,
0x01,
0x04,
0x03,
0x00,
0x00,
0x00,
tableMod[counter1],
0xF7
}
)
)
)
counter1 = counter1 + 1
end
end -- end timer #0
end -- f
tableMod = {2, 6, 3, 18, 27, 4, 3, 6, 8, 6, 1, 5, 9, 15, 14, 21} -- make this global in its own file
Regards, John. Here's another take using your code |
Beta Was this translation helpful? Give feedback.
-
|
Okay......I see how I could make the ENV Templates as tables that way and call them up with their own timer. How do I go about changing the forelast byte in the sysex string though? I would make another table, for example tableMod2, with values {0,1,1, 0 etc}. How to use the append Memoryblock in this case? Played around a little with shortening the memoryblock in the constructor and tmp:append(MemoryBlock(string.format("%2x %2x F7", tableMod2, tableMod[counter1]))) in the Callback but get a bad argument #2 to format, number expected, got table. |
Beta Was this translation helpful? Give feedback.
-
|
Like this maybe? --
-- Called when the panel is created, no modulators will exist at this point
-- consider this the panels constructor
--
constructor = function()
m=MemoryBlock("F0 0F 03 00 11 00 00 00 00 00 01 04 03 00 00") -- global
tableMod = {2,6,3,18,27,4,3,6,8,6,1,5,9,15,14,21} -- global
tab16th={0,1,0,1,0,0,1,0,0,1,1,1,0,1,0,0}
end
--
-- Called when a double-click event occurs on this component
--
myMethod = function(--[[ CtrlrComponent --]] comp, --[[ MouseEvent --]] event)
assert(#tab16th >= #tabMod)
console("timer starts on double click")
counter1 = 1
console("timer starts on double click and Counter1 = 1")
timer:setCallback(0, TimerCallback) -- TimerId 0
timer:startTimer(0, 500) -- Timer Id 0 500ms
end
TimerCallback = function(timerId)
if timerId == 0 then
if counter1 == #tableMod then
panel:getLabel("d"):setText("")
timer:stopTimer(timerId)
else
panel:getLabel("d"):setText(counter1 .. "\187 ")
local tmp = MemoryBlock(m)
tmp:append(MemoryBlock(string.format("%.2x",tab16th[counter1])))
tmp:append(MemoryBlock(string.format("%.2x F7", tableMod[counter1])))
panel:sendMidiMessageNow(CtrlrMidiMessage(tmp))
counter1 = counter1 + 1
end
end -- end timer #0
end -- f
|
Beta Was this translation helpful? Give feedback.
-
Yes, if it’s a global string any function can access it, but you have to understand global variables vs local in lua and scope in programming and more importantly be able to keep track of those variables in your program. If you don’t keep track of them, then you’ll end up with a global soup of variables and your program could become very unstable. Are you well familiar with all that? |
Beta Was this translation helpful? Give feedback.
-
Perhaps??? |
Beta Was this translation helpful? Give feedback.
-
|
Wow....that was easier than I thought...literally! I took all the tables out of the Constructor and placed them in the AssignModulators function which is called when the panel has finished loading. Since it's just a MemoryBlock that I want to change it only took some simple 'elseif then' statements to change that whole MemoryBlock with the string that I need. The other code that will append the string is already in place so....it's working! Thanks for putting up with me! |
Beta Was this translation helpful? Give feedback.
-
What could be the cause that all of a sudden this script is not working anymore? Clicking the dev button does not output anything anymore and I did not change anything in the scripts. |
Beta Was this translation helpful? Give feedback.
-
|
Hi @DRBAUS You’d need to post the panel for me to answer that ☝️ one. |
Beta Was this translation helpful? Give feedback.
-
|
Great!!!
I see now how I can manipulate that sysex string.
On to make the ENV TEMPLATES and put them to work.
Thanks everyone!
Op wo 9 mrt. 2022 07:08 schreef John Goodland ***@***.***>:
… Like this maybe?
--
-- Called when the panel is created, no modulators will exist at this point
-- consider this the panels constructor
--
constructor = function()
m=MemoryBlock("F0 0F 03 00 11 00 00 00 00 00 01 04 03 00 00") -- global
tableMod = {2,6,3,18,27,4,3,6,8,6,1,5,9,15,14,21} -- global
tab16th={0,1,0,1,0,0,1,0,0,1,1,1,0,1,0,0}
end
TimerCallback = function(timerId)
if timerId == 0 then
if counter1 == #tableMod then
panel:getLabel("d"):setText("")
timer:stopTimer(timerId)
else
panel:getLabel("d"):setText(counter1 .. "\187 ")
local tmp = MemoryBlock(m)
tmp:append(MemoryBlock(string.format("%.2x",tab16th[counter1])))
tmp:append(MemoryBlock(string.format("%.2x F7", tableMod[counter1])))
panel:sendMidiMessageNow(CtrlrMidiMessage(tmp))
counter1 = counter1 + 1
panel:getLabel("d"):append(tmp:toHexString(1))
end
end -- end timer #0
end -- f
------------------------------
Send Sysex With Delay Inbetween_2_0_4.zip
<https://github.com/RomanKubiak/ctrlr/files/8212117/Send.Sysex.With.Delay.Inbetween_2_0_4.zip>
—
Reply to this email directly, view it on GitHub
<#442 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASNL6INB7NKKXUCJD4BJQDLU7A54VANCNFSM5QCVPUPQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
@DRBAUS can you please select John's @dnaldoog previous post and mark it as the answer? thanks |
Beta Was this translation helpful? Give feedback.
-
Hi all,
I have the following (simplified) script working and running.
`--
-- Called when a double-click event occurs on this component
L1E1FULLON = function(--[[ CtrlrComponent --]] comp, --[[ MouseEvent --]] event)
timer:setCallback(0, TimerCallback) -- TimerId 0
timer:startTimer(0, 500) -- Timer Id 0 500ms
end
counter1 = 1
TimerCallback = function(timerId00)
--TIME 1--
--TIME 2--
elseif counter1 == 2 then
end
end`
However when I copy this script and change the timer to for example Id 1 and run it either from the same double click on label or even from a double click on a different label it starts to behave unpredictable. Usually after saving if I double click each of the label it starts sending the sysex from the other script.
Any suggestion what might cause this?
Beta Was this translation helpful? Give feedback.
All reactions