Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer table does not sort sizes correctly #646

Open
helrond opened this issue Feb 2, 2024 · 2 comments
Open

Transfer table does not sort sizes correctly #646

helrond opened this issue Feb 2, 2024 · 2 comments
Assignees

Comments

@helrond
Copy link
Member

helrond commented Feb 2, 2024

Describe the bug

Transfer sizes are not sorted correctly in the transfers table. They are sorted by number regardless of unit (KB, MB or GB)

To reproduce

Steps to reproduce the behavior:

  1. Sort the transfers table by size in Aurora prod and you'll see something like the following:
Screen Shot of mis-sorted transfer sizes

Expected behavior

Transfers should be sorted correctly by size regardless of units used.

Impact on your work

Not a huge deal but would be good to get sorted out.

@helrond
Copy link
Member Author

helrond commented Feb 7, 2024

From initial research it appears that this is happening because the number in the machine_file_size field exceeds the Javascript MAX_SAFE_INTEGER. Datatables suggests using orthogonal data however this approach is throwing an error in the filter_queryset method of the DatatableMixin. This could likely be solved by updating the library which supports the server-side rendering for Datatables (see, for example, the django_datatable_serverside_mixin.

@HaSistrunk
Copy link
Member

Decided to remove sort capability on that column, because that functionality is not worth the work-around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants