Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.vscode directory defaults? #24

Open
akrigline opened this issue Mar 29, 2018 · 5 comments
Open

.vscode directory defaults? #24

akrigline opened this issue Mar 29, 2018 · 5 comments
Labels
discussion enhancement New feature or request

Comments

@akrigline
Copy link
Contributor

Should we include a .vscode directory with gantry including our workspace recommended settings (disable eslint, enable standard, enable format on save from standard, recommended extensions, etc)?

It is a really nice thing that vscode lets us do, but at the same time this folder is basically useless for anyone using any other IDE.

@akrigline akrigline added enhancement New feature or request discussion labels Mar 29, 2018
@akrigline
Copy link
Contributor Author

@dfagan2 @stuarttannehill-rp
Thoughts here?

@dfagan2
Copy link
Contributor

dfagan2 commented Jul 18, 2018

@akrigline - i would prefer those recommendations just live in documentation somewhere, not as actual files. such documentation could even point to an un-merged PR/branch for easy pull down of actual files

@akrigline
Copy link
Contributor Author

I think that the .vscode directory adds a lot of value to people using vscode for very little cost to people not using vscode. Additionally, since R&P's front enders mostly all use it, it's basically become the opinion. As that opinion evolves, I expect that gantry will evolve with it.

Between all of these things, I would never want to spin up a project without a vscode directory:

  • Debugging Profiles
  • Suggested Extensions
  • Workspace Settings
    • Enable Standard linting and save on file
    • Disable conflicting extension settings (ESLint, Prettier, editor.formatOnSave)

@akrigline
Copy link
Contributor Author

I also am not opposed to the idea of us making an Atom or sublime text equivalent to the directory that lives in the repo. If gantry's goal is to make it easier to start working on a React app, these defaults will only help that.

@dfagan2
Copy link
Contributor

dfagan2 commented Jul 18, 2018

just want to be careful to keep our opinions on the React code, not other intangibles or preferences, as that can be a slippery slope. that said, i could be persuaded by the above.

@stuarttannehill-rp - what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants