-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROS2 Actions Support #130
Comments
Thanks for your question, I'd like to talk about the history of actionlib feature first
Based on the background, some comments below:
The rclnodejs should implement the actionlib feature
We have to support it for rclnodejs first
As the rosbridge v2.0 protocol doesn't support actionlib concept, so we may extend it if we want to support it (the corresponding changes may be made to roslibjs also).
That's correct. There is already an open issue - RobotWebTools/rclnodejs#469 to record this feature, so if you are willing to contribute to the implementation, you can submit your PR there. Currently, the rclnodejs still has a gap with Python/Cpp clients, see RobotWebTools/rclnodejs#498, please feel free if you are interested in any of them, thanks! |
Thanks for the explanation! I understand much better, I will take a look at RobotWebTools/rclnodejs#469 as well as the guidelines in RobotWebTools/rclnodejs#498 to determine if this is something I might be able to contribute to! |
Looks like actions are now supported in rclnodejs. Would extending the rosbridge protocol be the next step? On a related note - is the 'rosbridge v2.0 protocol' meant for ROS2? Or is it the second iteration of a protocol designed for ROS1? |
Yes, rclnodejs now supports actions, but we haven't had plan to extend the rosbridge protocol yet.
It stands for the 2nd version of rosbridge protocol for ROS1, that's is why it's difficult to extend to ROS2. |
Hi, I make website and use ros2-web-bridge to connect with ros2, I have problem on navigation2 because I can't use actions roslibjs and can't get result or feedback if I send pose direct via geometry_msgs/msg/PoseStamped. Can anyone help me for solution for these problem ?
|
Currently, |
Thank you for explain. I understand now between rclnodejs and ros2-web-bridge. |
@spygibas did success to manage it? i have the same issue? any good advice? |
rclnodejs acts as the back-end server at location robot , not same as roslibjs it at location on server website |
@spygibas many thanks for you replay any idea? |
@nadavis Hi, I suggest you to use these https://github.com/open-rmf/rmf-web |
@spygibas |
I have created a ROS2 package that implements ROS2 Actions and it would be great if I could call them through my webapp interface. Unfortunately, it seems ROS2 Actions are not supported yet.
What would it take to get this functionality? I have gathered that there are a couple reasons why this might be hard:
How could one assist in the effort to support ROS2 Actions in ROS2-web-bridge?
Would ROS2 actions need to be implemented inside roslibjs using the topics and services that are already supported by ROS2-web-bridge and the rosbridge v2.0 protocol? (I think this is more or less how roslibjs implemented the actionlib support)
or
Should actions support be implemented in rclnodejs first and then rosbridge v2.0 protocol be extended to support actions in some way?
I'd love to help in any way I can. I'm fairly new to ROS so please correct me if I'm misunderstanding.
In the meantime I will likely change my ROS package to provide the same functionality with a long-running service. (I know that is bad as services are meant to 'return quickly' but I'm not sure how else to do it)
The text was updated successfully, but these errors were encountered: