Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull up resistors for TM1637 key reading #29

Closed
SteveMicroCode opened this issue Oct 19, 2023 · 8 comments · Fixed by #30
Closed

Pull up resistors for TM1637 key reading #29

SteveMicroCode opened this issue Oct 19, 2023 · 8 comments · Fixed by #30
Assignees
Labels
enhancement New feature or request

Comments

@SteveMicroCode
Copy link

SteveMicroCode commented Oct 19, 2023

Just a comment after writing some code for the PIC that reads TM1637 keys. It will go on GitHub soon. Your code was an inspiration, useful background. I see your comments here about using fairly low value pull-ups when reading key data. I use the TM1637 with fairly short lines and no capacitors on clock or data and 10k pull-ups. Looking at the photos I think you had caps in place on the display module. Testing today with a clock period as low as 5us gave no problems in the no cap setup using 10k pull-up resistors. Think that may be why you needed lower value resistors? I think for many uses the 100 pf caps aren’t necessary and should be removed if fitted. If nothing else it avoids the need for a 100us clock period that wastes so much processor time

@RobTillaart RobTillaart self-assigned this Oct 19, 2023
@RobTillaart RobTillaart added the enhancement New feature or request label Oct 19, 2023
@RobTillaart
Copy link
Owner

Thanks for your comments, appreciated!
Need to reread them tomorrow (its too late here to dive into details) .

Need to think how to include this information into the readme.md so people can use them.
Thanks again!

@SteveMicroCode
Copy link
Author

SteveMicroCode commented Oct 19, 2023 via email

@RobTillaart
Copy link
Owner

RobTillaart commented Nov 22, 2023

Finally found some time for the issue. Expect release 0.3.9 soon (mainly documentation)

Do you have a public repo / link ?
if so I can include it in my readme.md.

@SteveMicroCode
Copy link
Author

SteveMicroCode commented Nov 22, 2023 via email

@SteveMicroCode
Copy link
Author

SteveMicroCode commented Nov 22, 2023 via email

@RobTillaart
Copy link
Owner

Thanks for the info,

Updated readme.md in the develop branch, including a section Hardware connection and performance
Most important things are mentioned with a reference to your test.

Thanks again!

@RobTillaart RobTillaart linked a pull request Nov 22, 2023 that will close this issue
@SteveMicroCode
Copy link
Author

SteveMicroCode commented Nov 22, 2023 via email

@SteveMicroCode
Copy link
Author

It happened again!

Trying once more:

https://github.com/SteveMicroCode/PIC-TM1637-Library-Code

RobTillaart added a commit that referenced this issue Nov 23, 2023
- update readme.md
  - section about hardware performance (Kudos to SteveMicroCode #29)
  - badges to platformIO + issues
  - improve related section
- update keywords.txt
- **keyScan()** replaces keyscan() => prefer camelCase (prep 0.4.0)
  - patched examples.
- minor edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants