Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Champion Mastery V4 docs might be outdated #1009

Open
katarem opened this issue Nov 15, 2024 · 0 comments
Open

[BUG] Champion Mastery V4 docs might be outdated #1009

katarem opened this issue Nov 15, 2024 · 0 comments
Labels
on hold: escalated to team This issue has been escalated to the team that owns the service.

Comments

@katarem
Copy link

katarem commented Nov 15, 2024

Bug Description
Variable chestGranted is missing on the response JSON body.

Problem Description
image
As you can check in the image, the docs describe that the response body should return the variable chestGranted, but I don't know if A) the docs are outdated or B) it isn't returning the available chest.

Expected Result
As I explained in the Problem Description, it either can be outdated docs or outdated response body on the REST API. It depends on what is actually the problem, the expected should or shouldn't include chestGranted in the response body and docs.

Actual Result
The docs say the Response Body comes with a variable called chestGranted but it is returning a response body without it. But I can't guess if the docs are outdated or the response body.

Developer Impact
Describe how this affects you as a developer. Please include the frequency and severity of the issue.

  • Frequency: Happens every call to the champion mastery endpoints
  • Severity: When it happens, my library returns null on chestGranted, which is bad for my users if they use Mastery object it will always point to a null.
  • Cost: It doesn't cost me anything as it is only a library for Java.
  • Efficiency: Requires me to hardcode the chestGranted variable on my code.

Player Impact
This bug doesn't affect League of Legends directly.

Preconditions
There aren't any preconditions.

Repro Steps
Step by step, what do you need to do to cause the bug? Note that GitHub will automagically number each step if you prefix the line with "1. "

  1. Step 1: Go to the endpoint docs of Champion-Mastery API, you will read "chestGranted" is supposedly returned in the Response Body.
@f3ar161 f3ar161 added the on hold: escalated to team This issue has been escalated to the team that owns the service. label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold: escalated to team This issue has been escalated to the team that owns the service.
Projects
None yet
Development

No branches or pull requests

2 participants