-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNN classifiers failing on Pippin analysis run #1449
Comments
There is indeed a recent sim update that broke scone, and may have broke SNN as well. I updated the sim to write full filter strings (e.g., 'DES-g') instead of the single-char representation (e.g., 'g'); this update is needed for SALT3training code. I fixed scone to store only the last character of the string, and SNN may need a similar fix. See #1446 |
Thanks for raising the issue and pinging me @paulshah and @RickKessler The issue is indeed the filter naming. No need to change SNN as we support changing the filter names. The solution can be implmented in PIPPIN by using As a test @paulshah I ran the --data for this job /scratch/midway2/rkessler/PIPPIN_OUTPUT/PS_ANALYSIS_DUST/3_CLAS/SNNTESTV19_z_data_1_DATADESSIM_SNNTRAINV19_z_TRAINDES_V19 with the change and worked. |
Resolved in dessn/Pippin@e4e25a1 |
Thank you @RickKessler , @anaismoller and @OmegaLambda1998 ! A different error is now raised in SNN : Extract from logfile : /scratch/midway2/rkessler/PIPPIN_OUTPUT/PS_ANALYSIS_DUST/3_CLAS/SNNTESTV19_z_data_1_DATADESSIM_SNNTRAINV19_z_TRAINDES_V19/output.log Traceback (most recent call last): |
@paulshah i couldn't find the folder, can you let me know if it is somewhere else? thanks! |
@anaismoller Unfortunately I've accidentally deleted it! I'll recreate it, but there's a bit of a log-jam on Midway at the moment which is stopping runs from completing. I'll post here when re-done. |
thanks @paulshah don't hesitate to ping me by email as sometimes I don't get the github notifications. Given the holidays I may need to get to this on january, hope it is not time sensitive! |
@anaismoller I've recreated the error : same logfile as above! |
Run :
Adapted PIPPIN analysis.yml to process simulated DES data.
Pippin Output dir :
/scratch/midway2/rkessler/PIPPIN_OUTPUT/PS_ANALYSIS_DUST
Error :
FAILED: SuperNNovaClassifier SNNTESTV19_z_data task (1 jobs, deps ['DATADESSIM'])
Other classifiers SNIRF, SCONE etc run OK.
Example output log error file :
/scratch/midway2/rkessler/PIPPIN_OUTPUT/PS_ANALYSIS_DUST/3_CLAS/SNNTESTV19_z_data_1_DATADESSIM_SNNTRAINV19_z_TRAINDES_V19
May be connected to recent updates, as same run had previously worked. Extract from logfile :
/project2/rkessler/PRODUCTS/miniconda/envs/snn_gpu/lib/python3.6/site-packages/sklearn/externals/joblib/externals/cloudpickle/cloudpickle.py:47: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
import imp
^[[32m[Loading FITRES file] ^[[0m
^[[33m[Warning: No FITRES file to load] ^[[0m
^[[33m[All lcs used for salt and photometry samples] ^[[0m
^[[32m[Computing saltfit splits for 2-way classification] ^[[0m
The text was updated successfully, but these errors were encountered: