Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some links in the maximal example are broken #148

Open
parafoxia opened this issue Sep 14, 2023 · 4 comments
Open

Some links in the maximal example are broken #148

parafoxia opened this issue Sep 14, 2023 · 4 comments

Comments

@parafoxia
Copy link

The banner and first badge links are broken in the [maximal example]. In fact, on closer inspection, it looks like they're not linked to anything?

![banner]()

![badge]()
![badge]()
@RichardLitt
Copy link
Owner

It was just an example. What do you think about adding an example URL in those links?

@parafoxia
Copy link
Author

I think it would be good. It would also make it clearer the banner is (I presume?) supposed to be an image.

@RichardLitt
Copy link
Owner

Sweet. Do you want to make a PR?

@parafoxia
Copy link
Author

Sure, I'll find some time this weekend to do it! (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@RichardLitt @parafoxia and others