feat: detect march and mcpu #2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are welcome to add an entry to the CHANGELOG.md as well |
fix build on riscv64
Cryolitia
added a commit
to Cryolitia-Forks/archriscv-packages
that referenced
this pull request
Oct 17, 2024
|
Awesome! It sure will help out the package maintainers a lot. |
felixonmars
pushed a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler don't support
march=native/mcpu=nativeon risvc64, either. This fix the compile failure on riscv64.Reported-by: https://archriscv.felixc.at/.status/log.htm?url=logs/proxmark3/proxmark3-4.18589-1.log
Refactor the way that detect whether
march=native/mcpu=nativeare supported on the platform, following the comment.Add an option
DONT_BUILD_NATIVEto suppress building withmarch=native/mcpu=native. For building it someone-self, it is helpful to generate the fastest binary, but for Linux or some other operating system distribution package maintainer, it is over optimized. We may build and package this software on a machine that isx86_64-v3but distribute it to a user that using an old hardware likeIntel Atom, and result in aSIGILL.Already tested it on
x86_64andriscv64