Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix precedence warning after perl-5.41.4 #1625

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Fix precedence warning after perl-5.41.4 #1625

merged 1 commit into from
Nov 3, 2024

Conversation

ferki
Copy link
Member

@ferki ferki commented Nov 3, 2024

This PR is a proposal to fix #1624 by replacing the affected comparisons (which also fixes the related ValuesAndExpressions::NotWithCompare perlcritic violations.)

Checklist

  • based on top of latest source code
  • changelog entry included
  • automated tests pass
  • git history is clean
  • git commit messages are well-written

This also fixes related ValuesAndExpressions::NotWithCompare perlcritic
violations.
@ferki ferki merged commit 6c8769e into master Nov 3, 2024
48 checks passed
@ferki ferki deleted the perl-5.41.4 branch November 3, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible precedence problem between ! and string eq
1 participant