Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make chunk visuals load through the VisualResourceIdentifier instead of exact paths #5402

Open
hhyyrylainen opened this issue Aug 25, 2024 · 2 comments · May be fixed by #5409
Open

Make chunk visuals load through the VisualResourceIdentifier instead of exact paths #5402

hhyyrylainen opened this issue Aug 25, 2024 · 2 comments · May be fixed by #5409
Labels
C# intermediate programming stage:microbe

Comments

@hhyyrylainen
Copy link
Member

hhyyrylainen commented Aug 25, 2024 •
edited
Loading

as this will make renaming files possible without breaking save compatibility

Thrive/src/microbe_stage/Spawners.cs

Line 225 in 4174a44

// TODO: redo chunk visuals with the loadable visual definitions

Update:
I realized that the CollisionShapeLoader component has a hardcoded path to a physics data object. Meaning that just these changes aren't sufficient to protect the chunks from save breakage when moving resource files around. So in addition the physics loading system should get a similar fix.
@github-project-automation github-project-automation bot moved this to Backburner in Thrive Planning Aug 25, 2024
@CI09
Copy link
Contributor

CI09 commented Aug 26, 2024 •
edited
Loading

I'd need help here:

image

Meshes is:
public List<VisualResourceData> Meshes;
Edit: this is no longer an issue.

@CI09 CI09 linked a pull request Aug 26, 2024 that will close this issue
Open
4 tasks
@hhyyrylainen
Copy link
Member Author

Why I set this as intermediate difficulty now:

I add the tags based on my initial impression which was that just a few places would need the data changed, but it's now turns out to be about 5-6 things. I marked it as intermediate as it doesn't require any novel new code, just reusing existing patterns in the codebase.

I don't think this qualifies as difficult as there's nothing really hard to do here, just quite a bit of fixing one thing and then everything depending on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C# intermediate programming stage:microbe
Projects
Thrive Planning
Status: Backburner
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Iron chunks now use visual identificator Revolutionary-Games/Thrive
2 participants
@hhyyrylainen @CI09