Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use purchase(confirmIn:) when possible #4606

Closed
wants to merge 7 commits into from

Conversation

fire-at-will
Copy link
Contributor

@fire-at-will fire-at-will commented Dec 17, 2024

Motivation

We've received some reports showing failures on iOS 18.2+ where StoreKit can't find the scene to present the purchase sheet over. According to some reports, using purchase(confirmIn:options:) can resolve this issue.

Description

This PR modifies the SDK to use purchase(confirmIn:options:) when it can fetch the current scene and when the API is available

TODO

Test, test, test!

@fire-at-will
Copy link
Contributor Author

@RCGitBot please test

@fire-at-will fire-at-will added the pr:fix A bug fix label Dec 17, 2024
@fire-at-will
Copy link
Contributor Author

@RCGitBot please test

@fire-at-will
Copy link
Contributor Author

@RCGitBot please test

@fire-at-will
Copy link
Contributor Author

@RCGitBot please test

@fire-at-will
Copy link
Contributor Author

@RCGitBot please test

@fire-at-will
Copy link
Contributor Author

Closing this PR since the underlying StoreKit bug is reproducible with purchase(confirmIn:options:) as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant