[Do not merge][Paywalls] Add Badge Modifier #4596
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 build increased size
Paywalls 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| DYLD.String Table | ⬆️ 116.8 kB |
| RevenueCatUI.StackComponentViewModel.StackComponentViewModel | ⬆️ 50.4 kB |
| Code Signature | ⬆️ 41.6 kB |
| RevenueCat.OfferingsFactory.OfferingsFactory | ⬆️ 23.3 kB |
| RevenueCatUI.StickyFooterComponentViewModel.StickyFooterComponent... | ⬆️ 14.8 kB |
View Treemap
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
MarkVillacampa
commented
Dec 16, 2024
| ) throws { | ||
| self.component = component | ||
| self.viewModels = viewModels | ||
|
|
||
| if let badge = component.badge { | ||
| badgeTextViewModel = try TextComponentViewModel( |
There was a problem hiding this comment.
Initialising the TextComponentViewModel of the badge in the StackComponentViewModel constructor so we can throw if necessary.
MarkVillacampa
commented
Dec 16, 2024
| self.bottomLeft = bottomLeft.flatMap { CGFloat($0) } | ||
| self.bottomRight = bottomRight.flatMap { CGFloat($0) } | ||
| } | ||
|
|
There was a problem hiding this comment.
Apparently this initialiser was not needed because we're not using explicit Doubles anywhere
MarkVillacampa
force-pushed
the
badge-component
branch
from
e9c2afb to
39bfe4e
Compare
MarkVillacampa
commented
Dec 16, 2024
| @@ -128,6 +151,7 @@ struct StackComponentStyle { | |||
| self.shape = shape?.shape | |||
| self.border = border?.border | |||
| self.shadow = shadow?.shadow | |||
| self.badge = badge?.badge(stackShape: self.shape) | |||
There was a problem hiding this comment.
The stack shape is only used to calculate the the corner radius of the edge-to-edge leading/trailing style badge, and make it match the parent stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-androidand hybridsMotivation
Description