[WEB-1757] Handle new backend error codes that may show in the redemption endpoint #4592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
commented
Dec 16, 2024
| return .configurationError | ||
| case .requestAlreadyInProgress, | ||
| .subscriberAttributesAreBeingUpdated: | ||
| return .operationAlreadyInProgressForProductError |
There was a problem hiding this comment.
Note that this error matches android's OperationAlreadyInProgressError without the ForProduct part... I think I prefer Android's naming but I didn't want to cause a breaking change due to this so I just reused the current naming.
vegaro
approved these changes
Dec 16, 2024
|
Will merge this for now but we can change the relative error code if needed. It should be a pretty uncommon error code in any case. |
This was referenced Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently these error codes would display in the API as "UnknownBackendError". This performs some better processing of these error codes.