Add ErrorView to CustomerCenter #4574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegaro
force-pushed
the
sdk-3704-make-customercenter-show-an-error-if-the-backend-request
branch
from
e1c7637 to
cc42021
Compare
1 build increased size
Paywalls 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| DYLD.String Table | ⬆️ 50.2 kB |
| Code Signature | ⬆️ 2.9 kB |
| Other | ⬆️ 55.5 kB |
View Treemap
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
…f-the-backend-request # Conflicts: # RevenueCatUI/CustomerCenter/ViewModels/CustomerCenterViewModel.swift
…f-the-backend-request # Conflicts: # RevenueCatUI/CustomerCenter/ViewModels/CustomerCenterViewModel.swift
tonidero
approved these changes
Dec 12, 2024
| .localizedString(forKey: "Something went wrong", | ||
| value: "Something went wrong", | ||
| table: nil) | ||
| CompatibilityContentUnavailableView( |
There was a problem hiding this comment.
Hmm wondering if it would make sense to have a "retry" button... It might also be worth at least displaying network errors with a different message... But we can improve that in future PRs.
There was a problem hiding this comment.
I wanted to do that, but it involves checking the type of network error, and thought it would complicate things a bit. Let's leave it for a future PR. I will add it to the list of things to do
vegaro
deleted the
sdk-3704-make-customercenter-show-an-error-if-the-backend-request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a simple error view when the Customer Center fails