Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RevenueCatUI missing from RevenueCat.xcframework? #4168

Closed
hansemannn opened this issue Aug 12, 2024 · 4 comments
Closed

RevenueCatUI missing from RevenueCat.xcframework? #4168

hansemannn opened this issue Aug 12, 2024 · 4 comments
Assignees
@aboedo
Labels
bug

Comments

@hansemannn
Copy link

Is it expected that RevenueCatUI is missing from the RevenueCat.xcframework? We are using RevenueCat for a long time and very extensively, but haven't seen a way to use this one so far. It's also not built via Carthage, so it's kind of a blocker for us, as we need a pre-packaged version of it.

Thanks in advance!
@hansemannn hansemannn added the bug label Aug 12, 2024
@RCGitBot
Copy link
Contributor

👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out!

@aboedo aboedo self-assigned this Aug 12, 2024
@aboedo
Copy link
Member

aboedo commented Aug 12, 2024

We don't have a pre-built xcframework for it, we'd have to vend it separately.

Let me see if I can set that up quickly

@aboedo aboedo mentioned this issue Aug 12, 2024
Merged
aboedo added a commit that referenced this issue Aug 15, 2024
@aboedo
export RevenueCatUI xcframework (#4172)
37f3fb1 
We don't currently export RevenueCatUI as an xcframework, which can be a
source of confusion and a dealbreaker for customers who need a pre-built
framework.
This adds RevenueCatUI's xcframework into the `export_xcframeworks`
lane, and includes the output in the `github_release` lane.


Should help address: 
- #4168
- #4146
- #4056
@aboedo aboedo closed this as completed Aug 29, 2024
@aboedo
Copy link
Member

aboedo commented Aug 29, 2024

It wasn't quick 😅 but the XCFramework is now officially a part of releases 🎉 so I'll tentatively mark this one as closed. Feel free to reopen if needed!

@RevenueCat RevenueCat deleted a comment from aboedo Aug 30, 2024
@hansemannn
Copy link
Author

hansemannn commented Sep 6, 2024 •
edited
Loading

@aboedo There seemed to be a signing issue with the attached binary, but I'll try a later release to see if it changes something. Just curious to see if that's a known issue atm.

EDIT: I have added some more details in #4250, so we can track it separately :)

Screenshot 2024-09-06 at 9 37 57 PM

@hansemannn hansemannn mentioned this issue Sep 8, 2024
Closed
7 tasks
nyeu pushed a commit that referenced this issue Oct 2, 2024
@aboedo @nyeu
export RevenueCatUI xcframework (#4172)
5b14f3b 
We don't currently export RevenueCatUI as an xcframework, which can be a
source of confusion and a dealbreaker for customers who need a pre-built
framework.
This adds RevenueCatUI's xcframework into the `export_xcframeworks`
lane, and includes the output in the `github_release` lane.


Should help address: 
- #4168
- #4146
- #4056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aboedo aboedo

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aboedo @hansemannn @RCGitBot