Fix workflow permission check logic #4084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
force-pushed
the
fix-trigger-all-test-workflow-logic
branch
from
28cc004 to
101e62a
Compare
|
@RCGitBot please test |
1 similar comment
|
@RCGitBot please test |
JayShortway
reviewed
Jul 19, 2024
|
@RCGitBot please test |
|
Will merge this for now, we can figure any other issues in followup PRs |
aboedo
reviewed
Jul 19, 2024
| id: verify | ||
| # ensure that only RevenueCat members can trigger this | ||
| run: | | ||
| RESPONSE=$(curl https://api.github.com/orgs/RevenueCat/members/${{ github.event.comment.user.login }}) | ||
| if [[ "$RESPONSE" == *"Not Found"* ]]; then | ||
| RESPONSE=$(curl -s -o /dev/null --head -w "%{http_code}" -H "Authorization: Bearer $READ_ORG_GITHUB_TOKEN" https://api.github.com/orgs/RevenueCat/members/${{ github.event.comment.user.login }}) |
There was a problem hiding this comment.
we should probably add a comment and maybe use \ to split this up into lines for clarity
|
@RCGitBot please test |
tonidero
added a commit
that referenced
this pull request
Jul 22, 2024
### Description Small cleanup from comments in #4084
Merged
nyeu
pushed a commit
that referenced
this pull request
Oct 2, 2024
### Description This improves the permission checking logic for running github actions. We also have it setup to only run actions by organization members, but this acts as an additional check. --------- Co-authored-by: Andy Boedo <[email protected]>
nyeu
pushed a commit
that referenced
this pull request
Oct 2, 2024
### Description Small cleanup from comments in #4084
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This improves the permission checking logic for running github actions. We also have it setup to only run actions by organization members, but this acts as an additional check.