[AUTOMATIC] Release/5.2.0 #4077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkVillacampa
approved these changes
Jul 17, 2024
The deploy workflow didn't run correctly, because of a regression introduced in #4025 . The problem is that we replaced the tag filters with a `when` clause, but the job itself was relying on us using the filter and running the second part of the deploy workflow from the tag itself and not the branch. I.e.: it wasn't entirely a chain of jobs, rather, there were two separate chains, one for releases and one for tags, running in the same job. This PR splits the jobs into two parts: one that creates the tag, and one that fires when a new tag is pushed, to create a release for it
|
|
|
|
Follow-up to #4079, removes the `when` and re-introduces filters as the way to trigger the job since `when` doesn't seem to work for tags
|
(I cancelled release checks because I pushed the tag manually the second time, and it was before that job could run) |
|
@aboedo Going to merge this since everything but the docs is shipped 💪 |
nyeu
pushed a commit
that referenced
this pull request
Oct 2, 2024
**This is an automatic release.** ### New Features * Added new paywall template to support multiple tiered subscriptions (#4022) via Josh Holtz (@joshdholtz) ### Bugfixes * Fix certain completion blocks not being dispatched on the main thread (#4058) via Mark Villacampa (@MarkVillacampa) * Only checks staged files for leftover API keys. (#4073) via JayShortway (@JayShortway) ### Other Changes * [Ci] Fix trigger to run all tests from github actions (#4075) via Andy Boedo (@aboedo) * added new workflow to trigger all tests (#4051) via Andy Boedo (@aboedo) * Reduce CI jobs (#4025) via Andy Boedo (@aboedo) --------- Co-authored-by: Andy Boedo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic release.
New Features
Bugfixes
Other Changes